Skip to content

[video_player_android] isBuffering flag always return true after calling seekTo method - fixed #9198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 5 commits into from
May 23, 2025
Merged

[video_player_android] isBuffering flag always return true after calling seekTo method - fixed #9198

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bf4fd71
[video_player_android] isBuffering flag always return true after call…
raju-muliyashiya May 4, 2025
e4a5254
Merge remote-tracking branch 'origin/main' into video_player_infinite…
raju-muliyashiya May 7, 2025
9f3bf4a
added native test case, update CHANGELOG.md and version pump
raju-muliyashiya May 7, 2025
22b40d2
undo CHANGELOG.md auto-formatted change
raju-muliyashiya May 13, 2025
ca70e19
Merge branch 'main' into video_player_infinite_buffer_on_seek_android…
stuartmorgan-g May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[video_player_android] isBuffering flag always return true after call… 
…ing seekTo method - fixed
  • Loading branch information
@raju-muliyashiya
raju-muliyashiya committed May 4, 2025
commit bf4fd711f62380284d61b81becba8493499c09cd
5 changes: 5 additions & 0 deletions packages/video_player/video_player_android/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## 2.8.3

* Fixes a [bug](https://github.com/flutter/flutter/issues/165149) where isBuffering flag always
* return true after seekTo any position
Copy link
Contributor

@camsim99 camsim99 May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit:

Suggested change
* Fixes a [bug](https://github.com/flutter/flutter/issues/165149) where isBuffering flag always
* return true after seekTo any position
* Fixes a [bug](https://github.com/flutter/flutter/issues/165149) where the `isBuffering` flag always
* returns true after seeking to any position.


## 2.8.2

* Fixes a [bug](https://github.com/flutter/flutter/issues/164689) that can cause video to
Expand Down
7 changes: 3 additions & 4 deletions ..._android/android/src/main/java/io/flutter/plugins/videoplayer/ExoPlayerEventListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,10 @@ public void onPlaybackStateChanged(final int playbackState) {
events.onBufferingUpdate(exoPlayer.getBufferedPosition());
break;
case Player.STATE_READY:
if (isInitialized) {
return;
if (!isInitialized) {
isInitialized = true;
sendInitialized();
Copy link
Contributor

@camsim99 camsim99 May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes in theory seems reasonable to me! Can you please add a test for this change?

Copy link
Contributor Author

@raju-muliyashiya raju-muliyashiya May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, will add test case.

}
isInitialized = true;
sendInitialized();
break;
case Player.STATE_ENDED:
events.onCompleted();
Expand Down
2 changes: 1 addition & 1 deletion packages/video_player/video_player_android/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: video_player_android
description: Android implementation of the video_player plugin.
repository: https://github.com/flutter/packages/tree/main/packages/video_player/video_player_android
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+video_player%22
version: 2.8.2
version: 2.8.3

environment:
sdk: ^3.6.0
Expand Down