Skip to content

[google_maps_flutter] Fixes exception when dispose is called while asynchronous update from didUpdateWidget is executed #9227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 7 commits into from
Sep 3, 2025
Merged

[google_maps_flutter] Fixes exception when dispose is called while asynchronous update from didUpdateWidget is executed #9227

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
320c1dc
Mount checks
JamesMcIntosh May 8, 2025
4b325f3
Single retrieval of controller
JamesMcIntosh May 8, 2025
366538f
Test mounted guard when updating state asynchronously from a new widget
JamesMcIntosh May 9, 2025
a1dbb38
Only update tile overlays and notifying of map creation if map is sti…
JamesMcIntosh May 10, 2025
67f96e6
Merge branch 'main' into RES-1352-mount-checks
stuartmorgan-g Sep 3, 2025
65487a7
Review feedback
stuartmorgan-g Sep 3, 2025
230512a
Merge branch 'main' into RES-1352-mount-checks
stuartmorgan-g Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Review feedback
  • Loading branch information
@stuartmorgan-g
stuartmorgan-g committed Sep 3, 2025
commit 65487a7493d22e206f8bf9991ea72692897f0f49
8 changes: 1 addition & 7 deletions packages/google_maps_flutter/google_maps_flutter/test/fake_google_maps_flutter_platform.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,7 @@ class FakeGoogleMapsFlutterPlatform extends GoogleMapsFlutterPlatform {
Completer<void>? initCompleter;

@override
Future<void> init(int mapId) {
if (initCompleter == null) {
return Future<void>.value();
}

return initCompleter!.future;
}
Future<void> init(int mapId) async => initCompleter?.future;

@override
Future<void> updateMapConfiguration(
Expand Down
1 change: 1 addition & 0 deletions packages/google_maps_flutter/google_maps_flutter/test/google_map_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,6 +619,7 @@ void main() {

await tester.pumpWidget(Container());

// This is done to force the update path while the widget is not mounted.
// ignore:invalid_use_of_protected_member
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If something is needed for testing, it should be annotated as such, rather than having warnings suppressed at the usage site.

Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind, I see why it has to be done this way.

googleMapState.didUpdateWidget(
GoogleMap(
Expand Down