Skip to content

[android_camera_camerax] Fix incorrect camera mirroring for front cameras on devices using ImageReader Impeller backend #9233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 15 commits into from
Jun 12, 2025
Merged

[android_camera_camerax] Fix incorrect camera mirroring for front cameras on devices using ImageReader Impeller backend #9233

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
7b3809a
mirror camera
camsim99 May 8, 2025
1351c20
fix tests + bump version
camsim99 May 9, 2025
ceb9865
added mirroring tests
jesswrd Jun 2, 2025
50897b2
resolved conflicts
jesswrd Jun 2, 2025
fe4ffb3
updated changelog
jesswrd Jun 2, 2025
bdf32a7
formatted files
jesswrd Jun 2, 2025
e2fba01
added helper function. has to check entire matrix
jesswrd Jun 11, 2025
c4b1fd6
Revert "added helper function. has to check entire matrix"
jesswrd Jun 11, 2025
0139263
added helper function. has to check entire matrix (take 2)
jesswrd Jun 11, 2025
a0c9bc9
Merge branch 'main' into camx_mirror_2
jesswrd Jun 11, 2025
ad702cc
formatted tests
jesswrd Jun 11, 2025
de19674
updated changelog
jesswrd Jun 11, 2025
0061ab0
Update packages/camera/camera_android_camerax/CHANGELOG.md
reidbaker Jun 12, 2025
541f537
add comment
camsim99 Jun 12, 2025
5fe7d84
Merge remote-tracking branch 'refs/remotes/origin/camx_mirror_2' into…
camsim99 Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
added mirroring tests
  • Loading branch information
@jesswrd
jesswrd committed Jun 2, 2025
commit ceb9865dabb174dae53cedd77a472754dde3560b
106 changes: 84 additions & 22 deletions packages/camera/camera_android_camerax/test/preview_rotation_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1036,8 +1036,13 @@ void main() {
// used.
expect(rotatedBox.child, isA<Transform>());

final Transform tranformedPreview = rotatedBox.child! as Transform;
expect((tranformedPreview.child! as Texture).textureId, cameraId);
final Transform transformedPreview = rotatedBox.child! as Transform;
final Matrix4 transformedPreviewMatrix = transformedPreview.transform;

// Since the front camera is in portrait mode, we expect the camera
// preview to be mirrored across the y-axis.
expect(transformedPreviewMatrix.storage[5], closeTo(-1.0, 0.0001));
expect((transformedPreview.child! as Texture).textureId, cameraId);
expect(
rotatedBox.quarterTurns,
expectedQuarterTurns,
Expand Down Expand Up @@ -1088,8 +1093,13 @@ void main() {
// used.
expect(rotatedBox.child, isA<Transform>());

final Transform tranformedPreview = rotatedBox.child! as Transform;
expect((tranformedPreview.child! as Texture).textureId, cameraId);
final Transform transformedPreview = rotatedBox.child! as Transform;
final Matrix4 transformedPreviewMatrix = transformedPreview.transform;

// Since the front camera is in landscape mode, we expect the camera
// preview to be mirrored across the x-axis.
expect(transformedPreviewMatrix.storage[0], closeTo(-1.0, 0.0001));
expect((transformedPreview.child! as Texture).textureId, cameraId);
expect(
rotatedBox.quarterTurns,
expectedQuarterTurns,
Expand Down Expand Up @@ -1139,8 +1149,13 @@ void main() {
// used.
expect(rotatedBox.child, isA<Transform>());

final Transform tranformedPreview = rotatedBox.child! as Transform;
expect((tranformedPreview.child! as Texture).textureId, cameraId);
final Transform transformedPreview = rotatedBox.child! as Transform;
final Matrix4 transformedPreviewMatrix = transformedPreview.transform;

// Since the front camera is in portrait mode, we expect the camera
// preview to be mirrored across the y-axis.
expect(transformedPreviewMatrix.storage[5], closeTo(-1.0, 0.0001));
expect((transformedPreview.child! as Texture).textureId, cameraId);
expect(
rotatedBox.quarterTurns,
expectedQuarterTurns,
Expand Down Expand Up @@ -1191,8 +1206,13 @@ void main() {
// used.
expect(rotatedBox.child, isA<Transform>());

final Transform tranformedPreview = rotatedBox.child! as Transform;
expect((tranformedPreview.child! as Texture).textureId, cameraId);
final Transform transformedPreview = rotatedBox.child! as Transform;
final Matrix4 transformedPreviewMatrix = transformedPreview.transform;

// Since the front camera is in landscape mode, we expect the camera
// preview to be mirrored across the x-axis.
expect(transformedPreviewMatrix.storage[0], closeTo(-1.0, 0.0001));
expect((transformedPreview.child! as Texture).textureId, cameraId);
expect(rotatedBox.quarterTurns, expectedQuarterTurns,
reason: getExpectedRotationTestFailureReason(
expectedQuarterTurns, rotatedBox.quarterTurns));
Expand Down Expand Up @@ -1273,8 +1293,13 @@ void main() {
// used.
expect(rotatedBox.child, isA<Transform>());

final Transform tranformedPreview = rotatedBox.child! as Transform;
expect((tranformedPreview.child! as Texture).textureId, cameraId);
final Transform transformedPreview = rotatedBox.child! as Transform;
final Matrix4 transformedPreviewMatrix = transformedPreview.transform;

// Since the front camera is in landscape mode, we expect the camera
// preview to be mirrored across the x-axis.
expect(transformedPreviewMatrix.storage[0], closeTo(-1.0, 0.0001));
expect((transformedPreview.child! as Texture).textureId, cameraId);
expect(rotatedBox.quarterTurns, expectedQuarterTurns,
reason: getExpectedRotationTestFailureReason(
expectedQuarterTurns, rotatedBox.quarterTurns));
Expand Down Expand Up @@ -1317,8 +1342,13 @@ void main() {
// used.
expect(rotatedBox.child, isA<Transform>());

final Transform tranformedPreview = rotatedBox.child! as Transform;
expect((tranformedPreview.child! as Texture).textureId, cameraId);
final Transform transformedPreview = rotatedBox.child! as Transform;
final Matrix4 transformedPreviewMatrix = transformedPreview.transform;

// Since the front camera is in landscape mode, we expect the camera
// preview to be mirrored across the x-axis.
expect(transformedPreviewMatrix.storage[0], closeTo(-1.0, 0.0001));
expect((transformedPreview.child! as Texture).textureId, cameraId);

final int clockwiseQuarterTurns = rotatedBox.quarterTurns + 4;
expect(clockwiseQuarterTurns, expectedQuarterTurns,
Expand Down Expand Up @@ -1361,8 +1391,13 @@ void main() {
// used.
expect(rotatedBox.child, isA<Transform>());

final Transform tranformedPreview = rotatedBox.child! as Transform;
expect((tranformedPreview.child! as Texture).textureId, cameraId);
final Transform transformedPreview = rotatedBox.child! as Transform;
final Matrix4 transformedPreviewMatrix = transformedPreview.transform;

// Since the front camera is in landscape mode, we expect the camera
// preview to be mirrored across the x-axis.
expect(transformedPreviewMatrix.storage[0], closeTo(-1.0, 0.0001));
expect((transformedPreview.child! as Texture).textureId, cameraId);

final int clockwiseQuarterTurns = rotatedBox.quarterTurns + 4;
expect(clockwiseQuarterTurns, expectedQuarterTurns,
Expand Down Expand Up @@ -1407,8 +1442,13 @@ void main() {
// used.
expect(rotatedBox.child, isA<Transform>());

final Transform tranformedPreview = rotatedBox.child! as Transform;
expect((tranformedPreview.child! as Texture).textureId, cameraId);
final Transform transformedPreview = rotatedBox.child! as Transform;
final Matrix4 transformedPreviewMatrix = transformedPreview.transform;

// Since the front camera is in landscape mode, we expect the camera
// preview to be mirrored across the x-axis.
expect(transformedPreviewMatrix.storage[0], closeTo(-1.0, 0.0001));
expect((transformedPreview.child! as Texture).textureId, cameraId);

final int clockwiseQuarterTurns = rotatedBox.quarterTurns + 4;
expect(clockwiseQuarterTurns, expectedQuarterTurns,
Expand Down Expand Up @@ -1504,8 +1544,13 @@ void main() {
// used.
expect(rotatedBox.child, isA<Transform>());

final Transform tranformedPreview = rotatedBox.child! as Transform;
expect((tranformedPreview.child! as Texture).textureId, cameraId);
final Transform transformedPreview = rotatedBox.child! as Transform;
final Matrix4 transformedPreviewMatrix = transformedPreview.transform;

// Since the front camera is in landscape mode, we expect the camera
// preview to be mirrored across the x-axis.
expect(transformedPreviewMatrix.storage[0], closeTo(-1.0, 0.0001));
expect((transformedPreview.child! as Texture).textureId, cameraId);

final int clockwiseQuarterTurns = rotatedBox.quarterTurns < 0
? rotatedBox.quarterTurns + 4
Expand Down Expand Up @@ -1601,8 +1646,20 @@ void main() {
// used.
expect(rotatedBox.child, isA<Transform>());

final Transform tranformedPreview = rotatedBox.child! as Transform;
expect((tranformedPreview.child! as Texture).textureId, cameraId);
final Transform transformedPreview = rotatedBox.child! as Transform;
final Matrix4 transformedPreviewMatrix = transformedPreview.transform;

// When the front camera is in landscape mode, we expect the camera
// preview to be mirrored across the x-axis. When the front camera
// is in portrait mode, we expect the camera preview to be mirrored
// across the y-axis.
if (currentDeviceOrientation == DeviceOrientation.landscapeLeft ||
currentDeviceOrientation == DeviceOrientation.landscapeRight) {
expect(transformedPreviewMatrix.storage[0], closeTo(-1.0, 0.0001));
} else {
expect(transformedPreviewMatrix.storage[5], closeTo(-1.0, 0.0001));
}
expect((transformedPreview.child! as Texture).textureId, cameraId);
final int clockwiseQuarterTurns = rotatedBox.quarterTurns < 0
? rotatedBox.quarterTurns + 4
: rotatedBox.quarterTurns;
Expand Down Expand Up @@ -1828,8 +1885,13 @@ void main() {
// used.
expect(rotatedBox.child, isA<Transform>());

final Transform tranformedPreview = rotatedBox.child! as Transform;
expect((tranformedPreview.child! as Texture).textureId, cameraId);
final Transform transformedPreview = rotatedBox.child! as Transform;
final Matrix4 transformedPreviewMatrix = transformedPreview.transform;

// Since the front camera is in landscape mode, we expect the camera
// preview to be mirrored across the x-axis.
expect(transformedPreviewMatrix.storage[0], closeTo(-1.0, 0.0001));
expect((transformedPreview.child! as Texture).textureId, cameraId);
expect(rotatedBox.quarterTurns, expectedQuarterTurns,
reason: getExpectedRotationTestFailureReason(
expectedQuarterTurns, rotatedBox.quarterTurns));
Expand Down