Skip to content

[camera_android_camerax] Swap out BroadcastReceiver for OrientationEventListener #9261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 8 commits into from
May 19, 2025
Merged

[camera_android_camerax] Swap out BroadcastReceiver for OrientationEventListener #9261

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
635375b
add debugging logging
camsim99 May 14, 2025
fd36ab6
clean up fix + add tests
camsim99 May 16, 2025
b1f2ab8
add missing test + doc
camsim99 May 16, 2025
98fb0db
fix typo + bump version
camsim99 May 16, 2025
e45c583
fix doc
camsim99 May 16, 2025
ca82952
typo
camsim99 May 16, 2025
3e84f11
add comment
camsim99 May 16, 2025
7b5481b
Update packages/camera/camera_android_camerax/android/src/main/java/i…
camsim99 May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix typo + bump version
  • Loading branch information
@camsim99
camsim99 committed May 16, 2025
commit 98fb0db4c4aa23c70b018846db72d4cf3652602d
6 changes: 6 additions & 0 deletions packages/camera/camera_android_camerax/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
## 0.6.17

* Replaces `BroadcastReceiver` usage with an `OrientationEventListener` to detect changes in device
orientation to fix issue where some devices do not report changes in device configuration if it
is rotated between the same sort of orientation (landscape/portrait).

## 0.6.16

* Fixes incorrect camera preview rotation for landscape-oriented devices.
Expand Down
2 changes: 1 addition & 1 deletion ...id_camerax/android/src/main/java/io/flutter/plugins/camerax/DeviceOrientationManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ public void start() {
@VisibleForTesting
@NonNull
/**
* Createa an {@link OrientationEventListener} that will call the callback method of the {@link
* Create an {@link OrientationEventListener} that will call the callback method of the {@link
* DeviceOrientationManagerProxyApi} whenever it is notified of a new device orientation and this
* {@DeviceOrientationManager} instance determines that the orientation of the device {@link
* Configuration} has changed.
Expand Down
2 changes: 1 addition & 1 deletion packages/camera/camera_android_camerax/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: camera_android_camerax
description: Android implementation of the camera plugin using the CameraX library.
repository: https://github.com/flutter/packages/tree/main/packages/camera/camera_android_camerax
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+camera%22
version: 0.6.16
version: 0.6.17

environment:
sdk: ^3.6.0
Expand Down