Skip to content

[camera,video_player] replace onSurfaceDestroyed with onSurfaceCleanup #9316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 7 commits into from
May 23, 2025
Merged

[camera,video_player] replace onSurfaceDestroyed with onSurfaceCleanup #9316

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
41b79e6
Update camera
stuartmorgan-g May 23, 2025
87ab97b
Update video player
stuartmorgan-g May 23, 2025
1663f4f
Dart format for camera
stuartmorgan-g May 23, 2025
4b4847e
Version bump for video player
stuartmorgan-g May 23, 2025
d0f7b51
More Dart autoformat
stuartmorgan-g May 23, 2025
ad0fdec
Fix formatter-mangled ignores
stuartmorgan-g May 23, 2025
d9b61b4
Merge branch 'main' into remove-onsurfacedestroyed
stuartmorgan-g May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix formatter-mangled ignores
  • Loading branch information
@stuartmorgan-g
stuartmorgan-g committed May 23, 2025
commit ad0fdecafae294885dc0119d0de76f3827875eb5
45 changes: 18 additions & 27 deletions packages/camera/camera_android_camerax/test/preview_rotation_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,9 +388,8 @@ void main() {
late int cameraId;
late DeviceOrientation testInitialDeviceOrientation;
late MockProcessCameraProvider mockProcessCameraProvider;
late MockCameraSelector Function(
// ignore: non_constant_identifier_names
{
late MockCameraSelector Function({
// ignore: non_constant_identifier_names
BinaryMessenger? pigeon_binaryMessenger,
// ignore: non_constant_identifier_names
PigeonInstanceManager? pigeon_instanceManager,
Expand Down Expand Up @@ -639,9 +638,8 @@ void main() {
late int cameraId;
late int testInitialDefaultDisplayRotation;
late MockProcessCameraProvider mockProcessCameraProvider;
late MockCameraSelector Function(
// ignore: non_constant_identifier_names
{
late MockCameraSelector Function({
// ignore: non_constant_identifier_names
BinaryMessenger? pigeon_binaryMessenger,
// ignore: non_constant_identifier_names
PigeonInstanceManager? pigeon_instanceManager,
Expand Down Expand Up @@ -895,9 +893,8 @@ void main() {
// Create and set up mock CameraSelector, mock ProcessCameraProvider, and media settings for test front camera.
// These settings do not matter for this test.
final MockCameraSelector mockFrontCameraSelector = MockCameraSelector();
final MockCameraSelector Function(
// ignore: non_constant_identifier_names
{
final MockCameraSelector Function({
// ignore: non_constant_identifier_names
BinaryMessenger? pigeon_binaryMessenger,
// ignore: non_constant_identifier_names
PigeonInstanceManager? pigeon_instanceManager,
Expand Down Expand Up @@ -1005,9 +1002,8 @@ void main() {
// Create and set up mock CameraSelector, mock ProcessCameraProvider, and media settings for test front camera.
// These settings do not matter for this test.
final MockCameraSelector mockFrontCameraSelector = MockCameraSelector();
final MockCameraSelector Function(
// ignore: non_constant_identifier_names
{
final MockCameraSelector Function({
// ignore: non_constant_identifier_names
BinaryMessenger? pigeon_binaryMessenger,
// ignore: non_constant_identifier_names
PigeonInstanceManager? pigeon_instanceManager,
Expand Down Expand Up @@ -1341,9 +1337,8 @@ void main() {
late int cameraId;
late MockCameraSelector mockFrontCameraSelector;
late MockProcessCameraProvider mockProcessCameraProviderForFrontCamera;
late MockCameraSelector Function(
// ignore: non_constant_identifier_names
{
late MockCameraSelector Function({
// ignore: non_constant_identifier_names
BinaryMessenger? pigeon_binaryMessenger,
// ignore: non_constant_identifier_names
PigeonInstanceManager? pigeon_instanceManager,
Expand Down Expand Up @@ -1586,9 +1581,8 @@ void main() {
// Create and set up mock front camera CameraSelector, mock ProcessCameraProvider, 270 degree sensor orientation,
// media settings for test front camera.
final MockCameraSelector mockFrontCameraSelector = MockCameraSelector();
final MockCameraSelector Function(
// ignore: non_constant_identifier_names
{
final MockCameraSelector Function({
// ignore: non_constant_identifier_names
BinaryMessenger? pigeon_binaryMessenger,
// ignore: non_constant_identifier_names
PigeonInstanceManager? pigeon_instanceManager,
Expand Down Expand Up @@ -1790,9 +1784,8 @@ void main() {
late AndroidCameraCameraX camera;
late int cameraId;
late MockCameraSelector mockBackCameraSelector;
late MockCameraSelector Function(
// ignore: non_constant_identifier_names
{
late MockCameraSelector Function({
// ignore: non_constant_identifier_names
BinaryMessenger? pigeon_binaryMessenger,
// ignore: non_constant_identifier_names
PigeonInstanceManager? pigeon_instanceManager,
Expand Down Expand Up @@ -1980,9 +1973,8 @@ void main() {
sensorRotationDegrees: testSensorOrientation,
);
// Set up front camera selection and initial device orientation as landscape right.
final MockCameraSelector Function(
// ignore: non_constant_identifier_names
{
final MockCameraSelector Function({
// ignore: non_constant_identifier_names
BinaryMessenger? pigeon_binaryMessenger,
// ignore: non_constant_identifier_names
PigeonInstanceManager? pigeon_instanceManager,
Expand Down Expand Up @@ -2047,9 +2039,8 @@ void main() {
);

// Set up front camera selection and initial device orientation as landscape right.
final MockCameraSelector Function(
// ignore: non_constant_identifier_names
{
final MockCameraSelector Function({
// ignore: non_constant_identifier_names
BinaryMessenger? pigeon_binaryMessenger,
// ignore: non_constant_identifier_names
PigeonInstanceManager? pigeon_instanceManager,
Expand Down