Skip to content

[url_launcher_ios] Fix test button text to work on iOS 26 #9766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 2 commits into from
Aug 15, 2025
Merged

[url_launcher_ios] Fix test button text to work on iOS 26 #9766

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
312f928
[url_launcher_ios] Fix test button text to work on iOS 26
jmagman Aug 6, 2025
58135e6
Review edit
jmagman Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/url_launcher/url_launcher_ios/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
## NEXT
* Fixes test button text to work on iOS 26.

## 6.3.4

* Updates to Pigeon 25.5.0.
Expand Down
9 changes: 5 additions & 4 deletions packages/url_launcher/url_launcher_ios/example/ios/RunnerUITests/URLLauncherUITests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,11 @@ class URLLauncherUITests: XCTestCase {
button.tap()
let webView = app.webViews.firstMatch
XCTAssertTrue(webView.waitForExistence(timeout: 30.0))
XCTAssertTrue(app.buttons["ForwardButton"].waitForExistence(timeout: 30.0))
XCTAssertTrue(app.buttons["Share"].exists)
XCTAssertTrue(app.buttons["OpenInSafariButton"].exists)
let doneButton = app.buttons["Done"]
XCTAssertTrue(app.buttons["OpenInSafariButton"].waitForExistence(timeout: 30.0))
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the CI run this test on xcode 26, or I should manually verify this change?

Copy link
Member Author

@jmagman jmagman Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this in a PR draft running Xcode 26 beta 5 #9748. I rebased that branch onto this one. It failed before, but now passes:

Testing started
Successfully ran iOS xctest for packages/url_launcher/url_launcher_ios/example

[packages/url_launcher/url_launcher_ios completed in 1m 29s]

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8706532896630430321/+/u/Run_package_tests/native_test/stdout


// iOS 18 is "Done". iOS 26 is "Close".
let doneButtonPredicate = NSPredicate(format: "label = 'Close' OR label = 'Done'")
let doneButton = app.buttons.element(matching: doneButtonPredicate).firstMatch
XCTAssertTrue(doneButton.waitForExistence(timeout: 30.0))
// This should just be doneButton.tap, but for some reason that stopped working in Xcode 15;
// tapping via coordinate works, however.
Expand Down