Skip to content

[video_player] Move Android buffer updates to Dart #9771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 10 commits into from
Aug 15, 2025
Merged

[video_player] Move Android buffer updates to Dart #9771

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5b227a4
Add player class as an initial abstraction
stuartmorgan-g Aug 6, 2025
fa87a01
Fold view state into the instance
stuartmorgan-g Aug 6, 2025
2f3a4df
Move event stream to the instance class
stuartmorgan-g Aug 7, 2025
1f88457
Move buffer update event synthesis to Dart
stuartmorgan-g Aug 7, 2025
fc1cd2a
Version bump
stuartmorgan-g Aug 7, 2025
395b7ba
Remove unused method
stuartmorgan-g Aug 7, 2025
796ab14
Fix capitalization
stuartmorgan-g Aug 7, 2025
93f36e3
Switch to a non-broadcast stream to keep queue behavior
stuartmorgan-g Aug 13, 2025
6d5e1a9
Merge branch 'main' into video-player-move-buffering-workaround
stuartmorgan-g Aug 13, 2025
c328f25
Review feedback
stuartmorgan-g Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unused method
  • Loading branch information
@stuartmorgan-g
stuartmorgan-g committed Aug 7, 2025
commit 395b7ba736321dd4af4e7836ce719cced331a411
4 changes: 0 additions & 4 deletions ...ideo_player_android/android/src/main/java/io/flutter/plugins/videoplayer/VideoPlayer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,6 @@ public void setDisposeHandler(@Nullable DisposeHandler handler) {
protected abstract ExoPlayerEventListener createExoPlayerEventListener(
@NonNull ExoPlayer exoPlayer, @Nullable SurfaceProducer surfaceProducer);

void sendBufferingUpdate() {
videoPlayerEvents.onBufferingUpdate(exoPlayer.getBufferedPosition());
}

private static void setAudioAttributes(ExoPlayer exoPlayer, boolean isMixMode) {
exoPlayer.setAudioAttributes(
new AudioAttributes.Builder().setContentType(C.AUDIO_CONTENT_TYPE_MOVIE).build(),
Expand Down