-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[google_sign_in] Add a method to clear auth tokens #9846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
auto-submit
merged 22 commits into
flutter:main
from
stuartmorgan-g:google-sign-in-add-clear-authorization
Sep 17, 2025
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
b072fa1
feat(google_sign_in): add clearAuthCache API
google-labs-jules[bot] 92adf68
Fix versioning
stuartmorgan-g 9e47e90
Rename new method
stuartmorgan-g 0666ee9
Move the app-facing method to the authorization client, and improve docs
stuartmorgan-g 83be004
Update migration guide
stuartmorgan-g f8c5625
Add a no-op on iOS
stuartmorgan-g e4a08c6
Fix up path overrides
stuartmorgan-g 04d1cb8
Parameter object
stuartmorgan-g 1218b97
Add app-facing package test
stuartmorgan-g 3101fb3
Fix Android
stuartmorgan-g cc26958
Revert extension package changes
stuartmorgan-g beb5dd5
Platform interface sanity test
stuartmorgan-g c7aefe7
Simpler lambdas
stuartmorgan-g d7d7b1a
Improve Java test
stuartmorgan-g 4272d38
Merge branch 'main' into google-sign-in-add-clear-authorization
stuartmorgan-g 0317ff2
Fix class pluralization
stuartmorgan-g 7b81325
Merge branch 'main' into google-sign-in-add-clear-authorization
stuartmorgan-g 62e9b68
Update platform interface refs
stuartmorgan-g 0bebd2b
Update Pigeon generation
stuartmorgan-g c4a725e
Merge branch 'main' into google-sign-in-add-clear-authorization
stuartmorgan-g cb94fce
Merge branch 'main' into google-sign-in-add-clear-authorization
stuartmorgan-g 5bc6f48
Update deps
stuartmorgan-g File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Parameter object
- Loading branch information
commit 04d1cb83c1cecddab38c179d1d8596beaad89342
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
packages/google_sign_in/google_sign_in_ios/test/google_sign_in_ios_test.mocks.dart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: do we always need to introduce an additional type for parameters? Is it specifically for pigeon?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to mark the class
final(so no need for the runtimeType check in==), or using an extension type?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have to, but the alternative is creating a new method and doing a cumbersome deprecation+migration every time we want to add a parameter.
No, it's unrelated to how platform implementations work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We sometimes make platform-specific subclasses of parameter classes, so I would prefer not to make them final.