Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix a missed test, re-add manual change to Pigeon generation per pack…
…age docs
  • Loading branch information
stuartmorgan-g committed Aug 28, 2025
commit 6a356a82a2665ca515f477b58249b55011a2cbb7
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,10 @@ class AndroidWebkitLibraryPigeonInstanceManager(
*/
fun <T> remove(identifier: Long): T? {
logWarningIfFinalizationListenerHasStopped()
val instance: Any? = getInstance(identifier)
if (instance is WebViewProxyApi.WebViewPlatformView) {
instance.destroy()
}
return strongInstances.remove(identifier) as T?
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@ public void onReceivedError() {
final android.webkit.WebResourceError error = mock(WebResourceError.class);
instance.onReceivedError(webView, request, error);

verify(mockApi).onReceivedError(eq(instance), eq(webView), eq(request), eq(error), any());
verify(mockApi)
.onReceivedRequestError(eq(instance), eq(webView), eq(request), eq(error), any());
}

@Test
Expand Down