-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[interactive_media_ads] Adds support for accessing data for an Ad #9972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
131811f
run pigeon
bparrishMines dc9ed24
add missing apis
bparrishMines 406e507
tests
bparrishMines 07122c9
fix tests sort of
bparrishMines 9acd11c
try fix tests maybe
bparrishMines 038f303
fix version bump
bparrishMines bf56d72
fix tests
bparrishMines 2f37abc
update adevent to
bparrishMines db23655
changelog update
bparrishMines 84a9fba
Merge branch 'main' of github.com:flutter/packages into ima_ad_ios
bparrishMines dff3de9
fix pigeon code
bparrishMines 660aa72
support a string value
bparrishMines 3af4706
fix tests
bparrishMines 5929f30
Merge branch 'main' of github.com:flutter/packages into ima_ad_ios
bparrishMines b00649e
comment the code
bparrishMines 52d7635
Merge branch 'main' of github.com:flutter/packages into ima_ad_ios
bparrishMines 7f77c09
version bump
bparrishMines 473357a
improve ad proxy code
bparrishMines 37ce423
Merge branch 'main' of github.com:flutter/packages into ima_ad_ios
bparrishMines 711064b
start of implementation
bparrishMines 88541d8
platform implementations
bparrishMines 3f2bc4a
Merge branch 'main' of github.com:flutter/packages into ima_ad_event_ad
bparrishMines 5839848
app facing interface implementation
bparrishMines 457ffe5
fix tests
bparrishMines 701e8e7
version bump
bparrishMines 6bff03f
make resource value nullable
bparrishMines 7f30199
analyze error
bparrishMines 634dbf5
Merge branch 'main' of github.com:flutter/packages into ima_ad_event_ad
bparrishMines 575eebd
update docs and add null checks
bparrishMines 8567b5a
add test for android ads
bparrishMines ccc3ad1
tests for ios
bparrishMines 4e93744
actually add ios tests
bparrishMines bc89942
include ad for test
bparrishMines f2bccf7
Merge branch 'main' of github.com:flutter/packages into ima_ad_event_ad
bparrishMines 76693c0
Merge branch 'main' of github.com:flutter/packages into ima_ad_event_ad
bparrishMines ba27a6a
update licenses
bparrishMines dda426c
update mocks
bparrishMines abdfa17
Merge branch 'main' of github.com:flutter/packages into ima_ad_event_ad
bparrishMines 7d8f720
some comment fixes
bparrishMines 88c1c05
erge branch 'main' of github.com:flutter/packages into ima_ad_event_ad
bparrishMines File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
some comment fixes
- Loading branch information
commit 7d8f720ee6754d247d914ca337bad50e2b97db9a
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do null height/width mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It means that it is unavailable: https://developers.google.com/interactive-media-ads/docs/sdks/android/client-side/api/reference/com/google/ads/interactivemedia/v3/api/CompanionAd#getWidth(). I change the zero to null to avoid foot guns. I'll update docs.