implement changes for platform consistency

packages/camera/camera/example/integration_test/camera_test.dart

@@ -276,11 +276,7 @@ void main() {
     await controller.initialize();
     await controller.prepareForVideoRecording();
 
-    if (Platform.isAndroid) {
-      await controller.startVideoRecording(enablePersistentRecording: true);
-    } else {
-      await controller.startVideoRecording();
-    }
+    await controller.startVideoRecording();
     await controller.setDescription(cameras[1]);
 
     await tester.pumpAndSettle(const Duration(seconds: 4));

packages/camera/camera/lib/src/camera_controller.dart

@@ -559,14 +559,14 @@ class CameraController extends ValueNotifier<CameraValue> {
   /// The video is returned as a [XFile] after calling [stopVideoRecording].
   /// Throws a [CameraException] if the capture fails.
   ///
-  /// If [enablePersistentRecording] parameter is set to true, configures the recording to be a persistent recording.
-  /// A persistent recording will only be stopped by explicitly calling [stopVideoRecording]
+  /// `enablePersistentRecording` parameter configures the recording to be a persistent recording.
+  /// A persistent recording can only be stopped by explicitly calling [stopVideoRecording]
   /// and will ignore events that would normally cause recording to stop,
   /// such as lifecycle events or explicit calls to [setDescription] while recording is in progress.
   /// Currently a no-op on platforms other than Android.
   Future<void> startVideoRecording({
     onLatestImageAvailable? onAvailable,
-    bool enablePersistentRecording = false,
+    bool enablePersistentRecording = true,
   }) async {
     _throwIfNotInitialized('startVideoRecording');
     if (value.isRecordingVideo) {

packages/camera/camera/test/camera_preview_test.dart

@@ -111,7 +111,7 @@ class FakeController extends ValueNotifier<CameraValue>
   @override
   Future<void> startVideoRecording({
     onLatestImageAvailable? onAvailable,
-    bool enablePersistentRecording = false,
+    bool enablePersistentRecording = true,
   }) async {}
 
   @override

packages/camera/camera_android_camerax/example/integration_test/integration_test.dart

@@ -245,7 +245,7 @@ void main() {
     await controller.initialize();
     await controller.prepareForVideoRecording();
 
-    await controller.startVideoRecording(enablePersistentRecording: true);
+    await controller.startVideoRecording();
 
     await controller.setDescription(cameras[1]);
 

packages/camera/camera_android_camerax/example/lib/camera_controller.dart

@@ -503,13 +503,13 @@ class CameraController extends ValueNotifier<CameraValue> {
   /// The video is returned as a [XFile] after calling [stopVideoRecording].
   /// Throws a [CameraException] if the capture fails.
   ///
-  /// If [enablePersistentRecording] is set to true, configures the recording to be a persistent recording.
+  /// `enablePersistentRecording` parameter configures the recording to be a persistent recording.
   /// A persistent recording will only be stopped by explicitly calling [stopVideoRecording]
   /// and will ignore events that would normally cause recording to stop,
   /// such as lifecycle events or explicit calls to [setDescription] while recording is in progress.
   Future<void> startVideoRecording({
     onLatestImageAvailable? onAvailable,
-    bool enablePersistentRecording = false,
+    bool enablePersistentRecording = true,
   }) async {
     _throwIfNotInitialized('startVideoRecording');
     if (value.isRecordingVideo) {
@@ -617,11 +617,8 @@ class CameraController extends ValueNotifier<CameraValue> {
 
   /// Sets the description of the camera.
   ///
-  /// By default, if a video recording is in progress, calling this method will cancel the current recording.
-  ///
-  /// To keep recording active while switching camera, start the
-  /// recording with [startVideoRecording] and set
-  /// `enablePersistentRecording` to `true`.
+  /// To avoid cancelling any active recording when calling this method,
+  /// start the recording with [startVideoRecording] with `enablePersistentRecording` to `true`.
   ///
   /// Throws a [CameraException] if setting the description fails.
   Future<void> setDescription(CameraDescription description) async {

packages/camera/camera_android_camerax/example/lib/main.dart

@@ -549,8 +549,6 @@ class _CameraExampleHomeState extends State<CameraExampleHome>
           color: Colors.blue,
           onPressed:
               cameraController == null ? null : onVideoRecordButtonPressed,
-          onLongPress:
-              cameraController == null ? null : onVideoRecordButtonLongPressed,
         ),
         IconButton(
           icon:
@@ -838,14 +836,6 @@ class _CameraExampleHomeState extends State<CameraExampleHome>
     });
   }
 
-  void onVideoRecordButtonLongPressed() {
-    startVideoRecording(enablePersistentRecording: true).then((_) {
-      if (mounted) {
-        setState(() {});
-      }
-    });
-  }
-
   void onStopButtonPressed() {
     stopVideoRecording().then((XFile? file) {
       if (mounted) {
@@ -896,9 +886,7 @@ class _CameraExampleHomeState extends State<CameraExampleHome>
     });
   }
 
-  Future<void> startVideoRecording({
-    bool enablePersistentRecording = false,
-  }) async {
+  Future<void> startVideoRecording() async {
     final CameraController? cameraController = controller;
 
     if (cameraController == null || !cameraController.value.isInitialized) {
@@ -912,9 +900,7 @@ class _CameraExampleHomeState extends State<CameraExampleHome>
     }
 
     try {
-      await cameraController.startVideoRecording(
-        enablePersistentRecording: enablePersistentRecording,
-      );
+      await cameraController.startVideoRecording();
     } on CameraException catch (e) {
       _showCameraException(e);
       return;

packages/camera/camera_android_camerax/test/android_camera_camerax_test.dart

@@ -3346,6 +3346,9 @@ void main() {
         when(
           mockPendingRecording.withAudioEnabled(!enableAudio),
         ).thenAnswer((_) async => mockPendingRecordingWithAudio);
+        when(
+          mockPendingRecording.asPersistentRecording(),
+        ).thenAnswer((_) async => mockPendingRecording);
         when(
           mockPendingRecordingWithAudio.start(any),
         ).thenAnswer((_) async => mockRecording);
@@ -3512,6 +3515,9 @@ void main() {
         when(
           mockPendingRecording.withAudioEnabled(!camera.enableRecordingAudio),
         ).thenAnswer((_) async => mockPendingRecording);
+        when(
+          mockPendingRecording.asPersistentRecording(),
+        ).thenAnswer((_) async => mockPendingRecording);
         when(
           mockPendingRecording.start(any),
         ).thenAnswer((_) async => mockRecording);
@@ -3567,6 +3573,7 @@ void main() {
         verifyNoMoreInteractions(camera.recorder);
         verify(mockPendingRecording.start(any)).called(1);
         verify(mockPendingRecording.withAudioEnabled(any)).called(1);
+        verify(mockPendingRecording.asPersistentRecording()).called(1);
         verifyNoMoreInteractions(mockPendingRecording);
       },
     );
@@ -3701,6 +3708,9 @@ void main() {
         when(
           mockPendingRecording.withAudioEnabled(!camera.enableRecordingAudio),
         ).thenAnswer((_) async => mockPendingRecording);
+        when(
+          mockPendingRecording.asPersistentRecording(),
+        ).thenAnswer((_) async => mockPendingRecording);
         when(
           mockProcessCameraProvider.bindToLifecycle(any, any),
         ).thenAnswer((_) => Future<Camera>.value(camera.camera));
@@ -3850,6 +3860,9 @@ void main() {
         when(
           mockPendingRecording.withAudioEnabled(!camera.enableRecordingAudio),
         ).thenAnswer((_) async => mockPendingRecording);
+        when(
+          mockPendingRecording.asPersistentRecording(),
+        ).thenAnswer((_) async => mockPendingRecording);
         when(
           mockPendingRecording.start(any),
         ).thenAnswer((_) async => mockRecording);
@@ -4388,7 +4401,6 @@ void main() {
       await camera.startVideoCapturing(
         VideoCaptureOptions(
           flutterSurfaceTextureId,
-          enablePersistentRecording: true,
         ),
       );
       await camera.setDescriptionWhileRecording(testFrontCameraDescription);
@@ -7181,6 +7193,9 @@ void main() {
       when(
         mockPendingRecording.withAudioEnabled(!camera.enableRecordingAudio),
       ).thenAnswer((_) async => mockPendingRecording);
+      when(
+        mockPendingRecording.asPersistentRecording(),
+      ).thenAnswer((_) async => mockPendingRecording);
       when(
         mockPendingRecording.start(any),
       ).thenAnswer((_) async => mockRecording);
@@ -7322,6 +7337,9 @@ void main() {
       when(
         mockPendingRecording.withAudioEnabled(!camera.enableRecordingAudio),
       ).thenAnswer((_) async => mockPendingRecording);
+      when(
+        mockPendingRecording.asPersistentRecording(),
+      ).thenAnswer((_) async => mockPendingRecording);
       when(
         mockPendingRecording.start(any),
       ).thenAnswer((_) async => mockRecording);
@@ -7463,6 +7481,9 @@ void main() {
       when(
         mockPendingRecording.withAudioEnabled(!camera.enableRecordingAudio),
       ).thenAnswer((_) async => mockPendingRecording);
+      when(
+        mockPendingRecording.asPersistentRecording(),
+      ).thenAnswer((_) async => mockPendingRecording);
       when(
         mockPendingRecording.start(any),
       ).thenAnswer((_) async => mockRecording);
@@ -7624,6 +7645,9 @@ void main() {
       when(
         mockPendingRecording.withAudioEnabled(!camera.enableRecordingAudio),
       ).thenAnswer((_) async => mockPendingRecording);
+      when(
+        mockPendingRecording.asPersistentRecording(),
+      ).thenAnswer((_) async => mockPendingRecording);
       when(
         mockPendingRecording.start(any),
       ).thenAnswer((_) async => mockRecording);
@@ -7789,6 +7813,9 @@ void main() {
       when(
         mockPendingRecording.withAudioEnabled(!camera.enableRecordingAudio),
       ).thenAnswer((_) async => mockPendingRecording);
+      when(
+        mockPendingRecording.asPersistentRecording(),
+      ).thenAnswer((_) async => mockPendingRecording);
       when(
         mockPendingRecording.start(any),
       ).thenAnswer((_) async => mockRecording);
@@ -7946,6 +7973,9 @@ void main() {
       when(
         mockPendingRecording.withAudioEnabled(!camera.enableRecordingAudio),
       ).thenAnswer((_) async => mockPendingRecording);
+      when(
+        mockPendingRecording.asPersistentRecording(),
+      ).thenAnswer((_) async => mockPendingRecording);
       when(
         mockPendingRecording.start(any),
       ).thenAnswer((_) async => mockRecording);

packages/camera/camera_platform_interface/lib/src/types/video_capture_options.dart

@@ -18,7 +18,7 @@ class VideoCaptureOptions {
     this.maxDuration,
     this.streamCallback,
     this.streamOptions,
-    this.enablePersistentRecording = false,
+    this.enablePersistentRecording = true,
   }) : assert(
          streamOptions == null || streamCallback != null,
          'Must specify streamCallback if providing streamOptions.',
@@ -44,15 +44,15 @@ class VideoCaptureOptions {
   /// Should only be set if a streamCallback is also present.
   final CameraImageStreamOptions? streamOptions;
 
-  /// When `true`, configures the recording to be a persistent recording.
+  /// Configures the recording to be a persistent recording.
   ///
-  /// A persistent recording will only be stopped by explicitly calling [CameraController.stopVideoRecording]
+  /// A persistent recording can only be stopped by explicitly calling [CameraController.stopVideoRecording]
   /// and will ignore events that would normally cause recording to stop, such as lifecycle events.
   ///
   /// On Android, you must set this parameter to `true`
   /// to avoid cancelling any active recording when calling [CameraController.setDescription].
   ///
-  /// Defaults to `false`.
+  /// Defaults to `true`.
   final bool enablePersistentRecording;
 
   @override