Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[camera]Fix CameraPreview freezes during startVideoRecording on iOS #1023

Merged
bparrishMines merged 8 commits into from
Mar 13, 2019
Merged

[camera]Fix CameraPreview freezes during startVideoRecording on iOS #1023

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
56e9eec
Fix CameraPreview freezes during startVideoRecording on iOS
cvolzke4 Jan 2, 2019
a140c07
Fix CameraPreview freezes during startVideoRecording on iOS - address…
cvolzke4 Jan 8, 2019
6dd5e2e
Fix CameraPreview freezes during startVideoRecording on iOS - address…
cvolzke4 Feb 21, 2019
8f28873
Fix CameraPreview freezes during startVideoRecording on iOS - address…
cvolzke4 Feb 27, 2019
b33f2af
Revert "Fix CameraPreview freezes during startVideoRecording on iOS -…
cvolzke4 Feb 27, 2019
98b5e39
Fix CameraPreview freezes during startVideoRecording on iOS - address…
cvolzke4 Feb 27, 2019
6e7e3bc
Merge branch 'master' into issue/25961-1
cvolzke4 Mar 8, 2019
9c346d4
version bump
bparrishMines Mar 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix CameraPreview freezes during startVideoRecording on iOS - address… 
… review comment
  • Loading branch information
@cvolzke4
cvolzke4 committed Feb 21, 2019
commit 6dd5e2edd22ba328c957606f962b8030a57ab486
3 changes: 3 additions & 0 deletions packages/camera/lib/camera.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,9 @@ class CameraController extends ValueNotifier<CameraValue> {

/// Prepare the capture session for video recording.
///
/// Use of this method is optional, but it may be called for performance
/// reasons on iOS.
///
/// Preparing audio can cause a minor delay in the CameraPreview view on iOS.
Copy link
Contributor

@sigurdm sigurdm Jan 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: leave an empty line after the first line in dart-doc comments

Copy link
Contributor Author

@cvolzke4 cvolzke4 Jan 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

/// If video recording is intended, calling this early eliminates this delay
/// that would otherwise be experienced when video recording is started.
Expand Down