Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@edman
Copy link
Contributor

@edman edman commented Jan 26, 2019

Apparently some dependencies like android.support.annotation were implicitly available, but that doesn't seem to be true anymore with AndroidX.

Tracked in flutter/flutter#23995.
Related to #1115

@edman
Copy link
Contributor Author

edman commented Jan 26, 2019

By the way, since AndroidX migration is a breaking change shouldn't we update the major version of affected libraries to respect semantic versioning?

@edman
Copy link
Contributor Author

edman commented Jan 30, 2019

Hi @mklim, could you have a look at this PR? I needed to make these changes to get your AndroidX migration working in my machine.

Copy link
Contributor

@mklim mklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Thanks for the PR, really appreciate it. I can't reproduce any problems from not including these dependencies, but I don't think having the implicit deps is great in the first place and I'm not seeing any additional problems from adding them explicitly.

By the way, since AndroidX migration is a breaking change shouldn't we update the major version of affected libraries to respect semantic versioning?

Yes. That was a terrible mistake, since been reverted and forward rolled with the right major versioning. Pub treats different digits as "major" depending on whether the package is at or below 1.0.0, and the original PRs didn't differentiate correctly between the packages.

@mklim mklim merged commit 0e14196 into flutter:master Jan 30, 2019
andreidiaconu pushed a commit to andreidiaconu/plugins that referenced this pull request Feb 17, 2019
andreidiaconu added a commit to andreidiaconu/plugins that referenced this pull request Feb 17, 2019
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants