This repository was archived by the owner on Feb 22, 2023. It is now read-only.
WebView JavasScript channels Android implementation. #1130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amirh
changed the title
amirh
changed the title
mklim
approved these changes
Jan 30, 2019
Contributor
mklim
left a comment
mklim
left a comment
There was a problem hiding this comment.
LGTM
Same as the other PR, not sure if it's totally worth it for this but this is the type of thing that you could add unit tests for.
|
|
||
| applySettings((Map<String, Object>) params.get("settings")); | ||
|
|
||
| if (params.containsKey("javascriptChannelNames")) { |
Contributor
There was a problem hiding this comment.
nit, optional: Consider breaking out the "javascriptChannelNames" magic string into a private constant on this class or a named variable. It'll prevent typo problems with getting the value.
| private final MethodChannel methodChannel; | ||
| private final String javaScriptChannelName; | ||
|
|
||
| JavaScriptChannel(MethodChannel methodChannel, String javaScriptChannelName) { |
Contributor
There was a problem hiding this comment.
nit: Can you also add docs explaining these params? I think it's just tricky enough that it's worth saying what they do here.
andreidiaconu
pushed a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
Platform implementation of the method channel API for adding and removing JavaScript channels. flutter#1116 adds the Dart side support, the current PR will land first. flutter/flutter#24837
andreidiaconu
added a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
karantanwar
pushed a commit
to karantanwar/plugins
that referenced
this pull request
Feb 19, 2019
Platform implementation of the method channel API for adding and removing JavaScript channels. flutter#1116 adds the Dart side support, the current PR will land first. flutter/flutter#24837
karantanwar
pushed a commit
to karantanwar/plugins
that referenced
this pull request
Feb 19, 2019
Platform implementation of the method channel API for adding and removing JavaScript channels. flutter#1116 adds the Dart side support, the current PR will land first. flutter/flutter#24837
alien190
added a commit
to alien190/plugins
that referenced
this pull request
Dec 24, 2021
…Session.abort() was removed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platform implementation of the method channel API for adding and removing JavaScript channels.
#1116 adds the Dart side support, the current PR will land first.
flutter/flutter#24837