Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@zhongwuzw
Copy link
Member

Description

Allow underscores anywhere for Javascript Channel name

Related Issues

flutter/flutter#35011

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

Copy link
Contributor

@amirh amirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Will land on green, thanks!

@zhongwuzw
Copy link
Member Author

Seems CI broken is not related.

@amirh amirh merged commit 283284f into flutter:master Sep 12, 2019
mormih pushed a commit to mormih/plugins that referenced this pull request Nov 17, 2019
…ame (flutter#1996)

* [webview_flutter] Allow underscores anywhere for Javascript Channel name
sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019
…ame (flutter#1996)

* [webview_flutter] Allow underscores anywhere for Javascript Channel name
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants