Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[Connectivity] add a method to request location on iOS (for iOS 13) #1999

Merged
cyanglaz merged 19 commits into from
Aug 29, 2019
Merged

[Connectivity] add a method to request location on iOS (for iOS 13) #1999

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
5c8d7f3
draft
Aug 8, 2019
7201c6f
add a method to request location
Aug 21, 2019
bb199d4
cleanup
Aug 21, 2019
0fd8cd9
update version
Aug 21, 2019
17f69cf
assert
Aug 22, 2019
69ab075
Update packages/connectivity/README.md
Aug 26, 2019
50a0ffb
Update packages/connectivity/README.md
Aug 26, 2019
169c5e6
Update packages/connectivity/README.md
Aug 26, 2019
782c472
Update packages/connectivity/README.md
Aug 26, 2019
0634d62
Update packages/connectivity/lib/connectivity.dart
Aug 26, 2019
c7666d6
Update packages/connectivity/lib/connectivity.dart
Aug 26, 2019
3a68b15
Update packages/connectivity/lib/connectivity.dart
Aug 26, 2019
ef2dcfb
Update packages/connectivity/lib/connectivity.dart
Aug 26, 2019
c0d9783
Update packages/connectivity/README.md
Aug 26, 2019
26b2874
review fixes
Aug 27, 2019
666821b
remove unnecesary result property
Aug 27, 2019
e577181
review fixes and add driver test for
Aug 28, 2019
12efe99
fix tests
Aug 29, 2019
f908024
Merge branch 'master' into connectivity_ios13
Aug 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update packages/connectivity/lib/connectivity.dart 
Co-Authored-By: Collin Jackson <[email protected]>
  • Loading branch information
@collinjackson
Chris Yang and collinjackson authored Aug 26, 2019
commit ef2dcfb78bcff2d1b9beabcab3c8298449806811
2 changes: 1 addition & 1 deletion packages/connectivity/lib/connectivity.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ class Connectivity {
/// Request to authorize the location service. Only on iOS.
Copy link
Contributor

@collinjackson collinjackson Aug 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// Request to authorize the location service. Only on iOS.
/// Request to authorize the location service (only on iOS).

I think Dartdoc comments are supposed to have tight first sentence with no other sentences on the first line. https://dart.dev/guides/language/effective-dart/documentation

///
/// Returns a [LocationAuthorizationStatus] if the location service has already been authorized or user authorized the location on
/// This request.
/// this request.
///
/// if the location information needs to be accessible all the time, set `requestAlwaysLocationUsage` to true. Note that the status
/// returned might not be [LocationAuthorizationStatus.authorizedAlways] even if you requested it. The user might have already chosen a location authorization
Expand Down