-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[url_launcher] Removed reference to rootViewController during initialization #2038
Conversation
cyanglaz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall
|
@cyanglaz Let me know if there is anything pending to merge the PR on my side. thanks! |
cyanglaz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one comment. And also the CI doesn't seem to be happy, could you fix it as well?
Fixed format.
|
@cyanglaz I have fixed code format and changed the parameter name. I'm not able to understand why build_all_plugins fails. It seems that name is missing from the pubspec but I didn't remove it. Could you help me on this ? Thanks |
|
@cyanglaz Sorry for pushing this but it would be great to have this merged. I'm happy to fix the build_all_plugins issue if you can help me figure out what is the underlying problem. Thanks. |
|
Sorry about that @vitor-gyant. Looking through it I think this was a bug unrelated to this PR that has been since fixed on master. If you merge master in it should be resolved. |
|
Sorry, there's been another breakage since then in flutter/flutter that's currently turning CI red now. It will be green again once flutter/flutter#40282 lands. |
|
@mklim Thanks it now works perfectly. Looking forward for the merge :) |
|
@mklim Thank you! |
|
@vitor-gyant thank you for the contribution! |
…ization (flutter#2038) The current plugin implementation stores a reference to the rootViewController during the initialisation which breaks scenarios like app2app. This PR does not store any variable to rootViewController but search through the VC hierarchy to get the top most VC in order to present the new vc.
…ization (flutter#2038) The current plugin implementation stores a reference to the rootViewController during the initialisation which breaks scenarios like app2app. This PR does not store any variable to rootViewController but search through the VC hierarchy to get the top most VC in order to present the new vc.
Description
The current plugin implementation stores a reference to the rootViewController during the initialisation which breaks scenarios like app2app. This PR does not store any variable to rootViewController but search through the VC hierarchy to get the top most VC in order to present the new vc.
Related Issues
flutter/flutter#33259
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?