This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[Camera] Fixes NullPointerException #2057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mklim
added
the
submit queue
Contributor
|
The CI failure should be fixed by flutter/flutter#40282. |
mormih
pushed a commit
to mormih/plugins
that referenced
this pull request
Nov 17, 2019
This PR fixes a possible NullPointerException when the device has only front-facing cameras. There are two versions of CamcorderProfile.get, the one currently in use will return null in case there is no back-facing camera. The second version uses the cameraId to avoid returning null. More: https://developer.android.com/reference/android/media/CamcorderProfile.html#get(int,%20int)
sungmin-park
pushed a commit
to sungmin-park/flutter-plugins
that referenced
this pull request
Dec 17, 2019
This PR fixes a possible NullPointerException when the device has only front-facing cameras. There are two versions of CamcorderProfile.get, the one currently in use will return null in case there is no back-facing camera. The second version uses the cameraId to avoid returning null. More: https://developer.android.com/reference/android/media/CamcorderProfile.html#get(int,%20int)
Akachu
pushed a commit
to Akachu/flutter_camera
that referenced
this pull request
Apr 27, 2020
This PR fixes a possible NullPointerException when the device has only front-facing cameras. There are two versions of CamcorderProfile.get, the one currently in use will return null in case there is no back-facing camera. The second version uses the cameraId to avoid returning null. More: https://developer.android.com/reference/android/media/CamcorderProfile.html#get(int,%20int)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a possible NullPointerException when the device has only front-facing cameras.
There are two versions of
CamcorderProfile.get, the one currently in use will return null in case there is no back-facing camera. The second version uses thecameraIdto avoid returning null.More: https://developer.android.com/reference/android/media/CamcorderProfile.html#get(int,%20int)
Related Issues
flutter/flutter#40164
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
How to test:
You should see something like the image below.