Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[device_info] Support v2 android embedder. #2163

Merged
cyanglaz merged 15 commits into from
Oct 21, 2019
Merged

[device_info] Support v2 android embedder. #2163

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
952b5d0
draft
Oct 7, 2019
ead4e1e
migrate device_info
Oct 7, 2019
5c8ebe7
refactor
Oct 7, 2019
6c96b7a
rename activities
Oct 8, 2019
e587caa
move handler non-publick
Oct 8, 2019
5597833
Update MainActivity.java
Oct 8, 2019
af6f345
fix gradle
Oct 11, 2019
05d9709
review fixes
Oct 14, 2019
2dd9444
e2e tests
Oct 15, 2019
5fee116
Update CHANGELOG.md
Oct 15, 2019
727a3b6
Update MainActivity.java
Oct 15, 2019
835793a
remove android x
Oct 21, 2019
b7e025a
Update CHANGELOG.md
Oct 21, 2019
f3dc369
place test files at the corret place
Oct 21, 2019
7d4c91c
Merge branch 'migrate_device_info' of github.com:cyanglaz/plugins int…
Oct 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor
  • Loading branch information
Chris Yang committed Oct 7, 2019
commit 5c8ebe7d7089ead9da01b0b6806ce462de8da452
32 changes: 18 additions & 14 deletions ...ges/device_info/android/src/main/java/io/flutter/plugins/deviceinfo/DeviceInfoPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,34 +4,38 @@

package io.flutter.plugins.deviceinfo;

import android.content.ContentResolver;
import io.flutter.embedding.engine.plugins.FlutterPlugin;
import io.flutter.plugin.common.BinaryMessenger;
import io.flutter.plugin.common.MethodChannel;
import io.flutter.plugin.common.PluginRegistry.Registrar;

/** DeviceInfoPlugin */
public class DeviceInfoPlugin implements FlutterPlugin {

MethodChannel channel;

/** Plugin registration. */
public static void registerWith(Registrar registrar) {
final MethodChannel channel =
new MethodChannel(registrar.messenger(), "plugins.flutter.io/device_info");

final MethodCallHandlerImpl handler =
new MethodCallHandlerImpl(registrar.context().getContentResolver());
channel.setMethodCallHandler(handler);
DeviceInfoPlugin plugin = new DeviceInfoPlugin();
plugin.setupMethodChannel(registrar.messenger(), registrar.context().getContentResolver());
}

@Override
public void onAttachedToEngine(FlutterPlugin.FlutterPluginBinding binding) {
final MethodChannel channel =
new MethodChannel(
binding.getFlutterEngine().getDartExecutor(), "plugins.flutter.io/device_info");

final MethodCallHandlerImpl handler =
new MethodCallHandlerImpl(binding.getApplicationContext().getContentResolver());
channel.setMethodCallHandler(handler);
setupMethodChannel(
binding.getFlutterEngine().getDartExecutor(),
binding.getApplicationContext().getContentResolver());
}

@Override
public void onDetachedFromEngine(FlutterPlugin.FlutterPluginBinding binding) {}
public void onDetachedFromEngine(FlutterPlugin.FlutterPluginBinding binding) {
channel.setMethodCallHandler(null);
Copy link
Contributor

@matthew-carroll matthew-carroll Oct 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommendation: consider defining a teardownMethodChannel() for symmetry with setupMethodChannel().

}

private void setupMethodChannel(BinaryMessenger messenger, ContentResolver contentResolver) {
channel = new MethodChannel(messenger, "plugins.flutter.io/device_info");
final MethodCallHandlerImpl handler = new MethodCallHandlerImpl(contentResolver);
channel.setMethodCallHandler(handler);
}
}