Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[url_launcher] Enable androidx and jetifier in android gradle properties #2174

Merged
bparrishMines merged 2 commits into from
Oct 10, 2019
Merged

[url_launcher] Enable androidx and jetifier in android gradle properties #2174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fac7a85
Enable androidx and jetifier in android gradle properties
bparrishMines Oct 10, 2019
5c3ed90
Fix version bump
bparrishMines Oct 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/url_launcher/url_launcher/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 5.1.6

* Fixes bug where androidx app won't build with this plugin by enabling androidx and jetifier in the android `gradle.properties`.

## 5.1.5

* Update homepage url after moving to federated directory.
Expand Down
2 changes: 2 additions & 0 deletions packages/url_launcher/url_launcher/android/gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
org.gradle.jvmargs=-Xmx1536M
android.useAndroidX=true
android.enableJetifier=true
Comment on lines +2 to +3
Copy link
Contributor

@Zazo032 Zazo032 Oct 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this two lines also be added to example/android/gradle.properties file? Also, as added to that file, should R8 be enabled here too?

(sorry if it's too late)

1 change: 1 addition & 0 deletions packages/url_launcher/url_launcher/example/android/gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
org.gradle.jvmargs=-Xmx1536M
android.enableR8=true
2 changes: 1 addition & 1 deletion packages/url_launcher/url_launcher/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: Flutter plugin for launching a URL on Android and iOS. Supports
web, phone, SMS, and email schemes.
author: Flutter Team <[email protected]>
homepage: https://github.com/flutter/plugins/tree/master/packages/url_launcher/url_launcher
version: 5.1.5
version: 5.1.6

flutter:
plugin:
Expand Down