Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Add tests in path_provider and url_launcher plugins #22

Merged
szakarias merged 6 commits into from
May 8, 2017
Merged

Add tests in path_provider and url_launcher plugins #22

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
43dbddd
wip
szakarias May 8, 2017
fc0b5aa
url_launcher test + missing copyrights
szakarias May 8, 2017
84cb5f5
formatting
szakarias May 8, 2017
2a6cc75
split into smaller tests
szakarias May 8, 2017
87f6f58
formatting
szakarias May 8, 2017
3b52e07
Merge branch 'master' of github.com:flutter/plugins into addTests
szakarias May 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
formatting
  • Loading branch information
@szakarias
szakarias committed May 8, 2017
commit 84cb5f59e7ef50c7ddba8d765f1c45903e538f9d
5 changes: 4 additions & 1 deletion packages/path-provider/test/path_provider_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,10 @@ void main() {

Copy link
Contributor

@mravn-google mravn-google May 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We start a new test here. Should ideally be separated into two invocations of test.

directory = await getApplicationDocumentsDirectory();

expect(log, equals(<MethodCall>[new MethodCall('getApplicationDocumentsDirectory')]));
expect(
log,
equals(
<MethodCall>[new MethodCall('getApplicationDocumentsDirectory')]));
Copy link
Contributor

@mravn-google mravn-google May 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A trailing comma may make dartfmt do something prettier.

expect(directory, isNull);

final String fakePath = "/foo/bar/baz";
Expand Down
8 changes: 6 additions & 2 deletions packages/url-launcher/test/url_launcher_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,14 @@ void main() {
});

await canLaunch('http://example.com/');
expect(log, equals(<MethodCall>[new MethodCall('canLaunch', 'http://example.com/')]));
expect(
log,
equals(
<MethodCall>[new MethodCall('canLaunch', 'http://example.com/')]));
Copy link
Contributor

@mravn-google mravn-google May 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

log.clear();

await launch('http://example.com/');
expect(log, equals(<MethodCall>[new MethodCall('launch', 'http://example.com/')]));
expect(log,
equals(<MethodCall>[new MethodCall('launch', 'http://example.com/')]));
});
}