Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[url_launcher] Migrate url_launcher_web to the platform interface #2237

Merged
harryterkelsen merged 3 commits into from
Oct 29, 2019
Merged

[url_launcher] Migrate url_launcher_web to the platform interface #2237

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c35d3f
[url_launcher] Migrate url_launcher_web to the platform interface
harryterkelsen Oct 25, 2019
5c4184b
Fix analyzer errors
harryterkelsen Oct 25, 2019
bfd992e
Add doc comments
harryterkelsen Oct 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix analyzer errors
  • Loading branch information
@harryterkelsen
harryterkelsen committed Oct 25, 2019
commit 5c4184b3ddf1808f98659f45fa76a622164a2b0c
9 changes: 4 additions & 5 deletions packages/url_launcher/url_launcher_web/lib/url_launcher_web.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import 'dart:async';
import 'dart:html' as html;

import 'package:flutter/services.dart';
import 'package:flutter_web_plugins/flutter_web_plugins.dart';
import 'package:meta/meta.dart';
import 'package:url_launcher_platform_interface/url_launcher_platform_interface.dart';
Expand All @@ -11,6 +10,9 @@ class UrlLauncherPlugin extends UrlLauncherPlatform {
UrlLauncherPlatform.instance = UrlLauncherPlugin();
}

/// Opens the given [url] in a new window.
///
/// Returns the newly created window.
@visibleForTesting
html.WindowBase openNewWindow(String url) {
return html.window.open(url, '');
Expand All @@ -25,10 +27,7 @@ class UrlLauncherPlugin extends UrlLauncherPlatform {
parsedUrl.isScheme('http') || parsedUrl.isScheme('https'));
}

/// Returns `true` if the given [url] was successfully launched.
///
/// For documentation on the other arguments, see the `launch` documentation
/// in `package:url_launcher/url_launcher.dart`.
@override
Future<bool> launch(
String url, {
@required bool useSafariVC,
Expand Down
1 change: 0 additions & 1 deletion packages/url_launcher/url_launcher_web/test/url_launcher_web_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
import 'dart:html' as html;

import 'package:flutter_test/flutter_test.dart';
import 'package:flutter_web_plugins/flutter_web_plugins.dart';
import 'package:url_launcher/url_launcher.dart';
import 'package:url_launcher_web/url_launcher_web.dart';
import 'package:url_launcher_platform_interface/url_launcher_platform_interface.dart';
Expand Down