Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[google_sign_in] Port plugin to use the federated Platform Interface #2266

Merged
ditman merged 5 commits into from
Nov 15, 2019
Merged

[google_sign_in] Port plugin to use the federated Platform Interface #2266

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
652fbf6
Port google_sign_in.dart to use the federated Platform Interface,
ditman Oct 31, 2019
edbdff3
Appease lint
ditman Nov 12, 2019
3c5b79b
Ignore google_sign_in_platform_interface on all-plugins-app call.
ditman Nov 12, 2019
7d626a8
Address PR feedback
ditman Nov 13, 2019
2d36764
Address PR feedback.
ditman Nov 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Address PR feedback.
  • Loading branch information
@ditman
ditman committed Nov 15, 2019
commit 2d367642673d511d30eeee8135db030db2eeea45
14 changes: 9 additions & 5 deletions packages/google_sign_in/google_sign_in/lib/google_sign_in.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ class GoogleSignIn {
/// Initializes global sign-in configuration settings.
///
/// The [signInOption] determines the user experience. [SigninOption.games]
/// must not be used on iOS or web.
/// is only supported on Android.
///
/// The list of [scopes] are OAuth scope codes to request when signing in.
/// These scope codes will determine the level of data access that is granted
Expand Down Expand Up @@ -167,8 +167,8 @@ class GoogleSignIn {
hostedDomain: hostedDomain);
}

/// Factory for creating sign in suitable for games. This option must not be
/// used on iOS or web because the games API is not supported.
/// Factory for creating sign in suitable for games. This option is only
/// supported on Android.
factory GoogleSignIn.games() {
return GoogleSignIn(signInOption: SignInOption.games);
}
Expand All @@ -186,8 +186,8 @@ class GoogleSignIn {
/// Error code indicating that attempt to sign in failed.
static const String kSignInFailedError = 'sign_in_failed';

/// Option to determine the sign in user experience. [SignInOption.games] must
/// not be used on iOS or web.
/// Option to determine the sign in user experience. [SignInOption.games] is
/// only supported on Android.
final SignInOption signInOption;

/// The list of [scopes] are OAuth scope codes requested when signing in.
Expand Down Expand Up @@ -253,6 +253,10 @@ class GoogleSignIn {
///
/// At most one in flight call is allowed to prevent concurrent (out of order)
/// updates to [currentUser] and [onCurrentUserChanged].
///
/// The optional, named parameter [canSkipCall] lets the plugin know that the
/// method call may be skipped, if there's already [_currentUser] information.
/// This is used from the [signIn] and [signInSilently] methods.
Future<GoogleSignInAccount> _addMethodCall(
Function method, {
bool canSkipCall = false,
Expand Down