Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add an analysis rule for DartDocs
Adds a rule just for `android_intent` that makes sure that there are no
undocumented public members. This will prevent the DartDocs from
regressing. Also updates the main repo's analysis options to migrate
from some deprecated options.

If/when all the plugins have their DartDocs updated this
package-specific `analysis_options.yaml` should be removed, and the
DartDoc rule should be moved up to the top level.
  • Loading branch information
Michael Klimushyn committed Nov 12, 2019
commit 110676afd09ccc601da784109127b45cb19b646f
7 changes: 2 additions & 5 deletions analysis_options.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,8 @@

analyzer:
language:
enableStrictCallChecks: true
enableSuperMixins: true
enableAssertInitializer: true
strict-inference: true
strict-raw-types: true
strong-mode:
implicit-dynamic: false
errors:
Expand Down Expand Up @@ -113,12 +112,10 @@ linter:
- prefer_is_empty
- prefer_is_not_empty
- prefer_void_to_null
- public_member_api_docs
# - recursive_getters # https://github.com/dart-lang/linter/issues/452
- slash_for_doc_comments
- sort_constructors_first
- sort_unnamed_constructors_first
- super_goes_last
# - type_annotate_public_apis # subset of always_specify_types
- type_init_formals
# - unawaited_futures # https://github.com/flutter/flutter/issues/5793
Expand Down
11 changes: 11 additions & 0 deletions packages/android_intent/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# This exists to add a lint for missing API docs just on this specific package,
# since not all packages have coverage for all their public members yet and
# adding it in would be non-trivial. `public_member_api_docs` should be applied
# to new packages going forward, and ideally the main `analysis_options.yaml`
# file as soon as possible.

include: ../../analysis_options.yaml

linter:
rules:
- public_member_api_docs