This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[url_launcher] Add support for macos #2377
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collinjackson
approved these changes
Dec 9, 2019
| @@ -0,0 +1,58 @@ | |||
| // Copyright 2019 Google LLC | |||
Contributor
There was a problem hiding this comment.
Should be Chromium license
| @@ -0,0 +1,3 @@ | |||
| // The url_launcher_platform_interface defaults to MethodChannelUrlLauncher | |||
| // as its instance, which is all the macOS implementation needs. This file | |||
| // is here to silence warnings when publishing to pub. No newline at end of file | |||
Contributor
There was a problem hiding this comment.
IMO we should make this comment into a TODO (to not require this file), file an issue against pub and reference it here.
Contributor
Author
|
Closing in favor of #2386 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for macOS along with a macos example implementation
Related Issues
flutter/flutter#41721
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?