Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[google_sign_in] Fix crash on iOS caused by null hostedDomain #2521

Closed
ryanheise wants to merge 9 commits into from
Closed

[google_sign_in] Fix crash on iOS caused by null hostedDomain #2521

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
828bec3
Fix crash on iOS caused by null hostedDomain
ryanheise Feb 12, 2020
212f262
Merge branch 'master' into fix_google_sign_in_crash
ryanheise Jun 12, 2020
2411dbb
Remove default parameter value for hostedDomain
ryanheise Jun 12, 2020
87bc053
Move hostedDomain null check into objective c
ryanheise Aug 10, 2020
e2ee1df
Fix formatting
ryanheise Aug 10, 2020
90372aa
Update version in pubspec only
ryanheise Aug 10, 2020
8e7725e
Merge branch 'master' into fix_google_sign_in_crash
ryanheise Aug 10, 2020
f6b409d
format
ryanheise Aug 10, 2020
56663bd
Call method channel on main thread
ryanheise Aug 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move hostedDomain null check into objective c
  • Loading branch information
@ryanheise
ryanheise committed Aug 10, 2020
commit 87bc053559853b4e73ee50c3538dec731ba48c1c
3 changes: 2 additions & 1 deletion packages/google_sign_in/google_sign_in/ios/Classes/FLTGoogleSignInPlugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,8 @@ - (void)handleMethodCall:(FlutterMethodCall *)call result:(FlutterResult)result
[GIDSignIn sharedInstance].clientID = plist[kClientIdKey];
[GIDSignIn sharedInstance].serverClientID = plist[kServerClientIdKey];
[GIDSignIn sharedInstance].scopes = call.arguments[@"scopes"];
[GIDSignIn sharedInstance].hostedDomain = call.arguments[@"hostedDomain"];
NSString *hostedDomain = call.arguments[@"hostedDomain"];
[GIDSignIn sharedInstance].hostedDomain = hostedDomain != (id)[NSNull null] ? hostedDomain : @"";
result(nil);
} else {
result([FlutterError errorWithCode:@"missing-config"
Expand Down