Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[google_maps_flutter] Migrate plugin to platform_interface API. #2674

Merged
ditman merged 39 commits into from
Apr 24, 2020
Merged

[google_maps_flutter] Migrate plugin to platform_interface API. #2674

Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
65a563b
add google_maps_flutter_platform_interface
cylyl Mar 4, 2020
30abbed
removed unused_local_variable
cylyl Mar 4, 2020
a064377
format
cylyl Mar 4, 2020
807ee11
format
cylyl Mar 4, 2020
b795177
format#
cylyl Mar 4, 2020
cf7bef9
Move MethodChannel code to MethodChannelGoogleMapsFlutter
cylyl Mar 5, 2020
3e5af41
Update dependencies
cylyl Mar 5, 2020
db8b602
add buildView method
cylyl Mar 9, 2020
ad1fb3b
update pubspec
cylyl Mar 9, 2020
161c24d
bugs fix
cylyl Mar 20, 2020
aaa7ac8
Some adjustments to the PR.
ditman Mar 22, 2020
cb144fb
dartfmt -w .
ditman Mar 22, 2020
aace184
Expose the MethodChannel so e2e tests are happy.
ditman Mar 23, 2020
5d24763
Move platform into src so we can create a barrel file to export stuff.
ditman Mar 24, 2020
2304ef8
Create barrel file to export only certain things from src
ditman Mar 24, 2020
a3514c3
Move LatLng and LagLngBounds to the platform interface package. Reexp…
ditman Mar 24, 2020
609b68e
Move ui.dart to platform_interface. Expose .toJson so it can be used …
ditman Mar 24, 2020
4207150
Move Polygon and Polyline, and all the related types.
ditman Mar 24, 2020
a63dd82
Move Circle and Marker files to platform_interface.
ditman Mar 24, 2020
2008312
Move callbacks, camera and screen cordinate to platform interface. Ex…
ditman Mar 25, 2020
2fa370d
Adapt controller and map widget to new API. Expose _toX methods as to…
ditman Mar 25, 2020
5be2fa0
dartfmt -w .
ditman Mar 25, 2020
92d600b
Use EntityUpdate classes in the corresponding platform interface
ditman Mar 25, 2020
967bb00
Modify the platform interface in methods that return map boundaries to
ditman Mar 25, 2020
967c64a
Utilize MarkerId instances instead of Strings in the relevant methods.
ditman Mar 25, 2020
868126d
Return futures from the platform directly, no need to await for those.
ditman Mar 26, 2020
44641c3
Make mapId a mandatory parameter on the interface methods.
ditman Mar 27, 2020
82aef2a
Add the 11 native event Streams to the platform interface.
ditman Mar 27, 2020
c652fbd
Connect to the streams coming from the platform interface.
ditman Mar 27, 2020
0761388
Rename test according to what it tests.
ditman Mar 31, 2020
9fa6e10
Move CameraPositionCallback to the platform interface
ditman Mar 31, 2020
f2e8efc
Move takeSnapshot to platform_interface.
ditman Apr 1, 2020
1a05b66
Revert changes to the example.
ditman Apr 3, 2020
a351e76
Remove .gitignore from example dir
ditman Apr 3, 2020
0b6986d
Appease analyze some more.
ditman Apr 3, 2020
73ccd2c
Bump version and update CHANGELOG.
ditman Apr 20, 2020
fcdc7b1
Use published version of platform_interface package.
ditman Apr 21, 2020
3df7745
Address PR comments.
ditman Apr 23, 2020
8ce802a
Merge branch 'master' into gmaps_core_plugin
ditman Apr 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Expose the MethodChannel so e2e tests are happy.
  • Loading branch information
@ditman
ditman committed Apr 21, 2020
commit aace1846a3151962c6506291f1eba6f6272cbc98
7 changes: 5 additions & 2 deletions packages/google_maps_flutter/google_maps_flutter/lib/src/controller.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,11 @@ class GoogleMapController {
// TODO: Remove this once tests are migrated to not need this.
@visibleForTesting
MethodChannel get channel {
return (_googleMapsFlutterPlatform as MethodChannelGoogleMapsFlutter)
.channel;
if (_googleMapsFlutterPlatform is MethodChannelGoogleMapsFlutter) {
return (_googleMapsFlutterPlatform as MethodChannelGoogleMapsFlutter)
.channel;
}
return null;
}

final _GoogleMapState _googleMapState;
Expand Down