Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@klaes-ashford
Copy link
Contributor

@klaes-ashford klaes-ashford commented Apr 29, 2020

Description

This would enable [google_maps_flutter] Add pointForMeters to plugin in iOS #2503

Related Issues

#2503
#2503 (comment)

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@klaes-ashford
Copy link
Contributor Author

@ditman I am unable to add reviewers for this PR. please review this. thanks.

@ditman ditman requested review from cyanglaz and ditman April 29, 2020 18:02
@klaes-ashford klaes-ashford requested a review from ditman May 2, 2020 11:54
@klaes-ashford
Copy link
Contributor Author

review suggestions has been implemented. method channel has been renamed to projection#getPointsForMeters so that it'd leave the door open to creating a more complete set of projection calls as per @ditman's suggestion. @cyanglaz, please verify if this is the way to go.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@klaes-ashford
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@klaes-ashford klaes-ashford requested a review from cyanglaz May 15, 2020 06:25
@cyanglaz
Copy link
Contributor

@klaes-ashford I left some comments on the PR for plugin. We will land this when the other PR is also ready.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants