Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[google_maps_flutter] Overhaul lifecycle management in GoogleMapsPlugin #3213

Merged
amirh merged 14 commits into from
Oct 29, 2020
Merged

[google_maps_flutter] Overhaul lifecycle management in GoogleMapsPlugin #3213

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
c977679
GoogleMapController is now uniformly driven by implementing DefaultLi…
math1man Oct 27, 2020
e934a18
Update CHANGELOG.md and version
math1man Oct 27, 2020
9bdc386
Merge remote-tracking branch 'origin/master'
math1man Oct 27, 2020
96cf26b
Fix formatting issues
math1man Oct 28, 2020
62476dc
Update GoogleMapControllerTest
math1man Oct 28, 2020
a8e02a4
Merge remote-tracking branch 'origin/master'
math1man Oct 28, 2020
b920973
Remove extraneous import
math1man Oct 28, 2020
ea016b8
Update GoogleMapsPlugin.ProxyLifecycleProvider to use handleLifecycle…
math1man Oct 28, 2020
d6c9014
Merge remote-tracking branch 'origin/master'
math1man Oct 28, 2020
5f479f0
Update version from 1.1.0 to 1.0.5
math1man Oct 28, 2020
2c182a9
Merge remote-tracking branch 'origin/master'
math1man Oct 28, 2020
039e3ce
Add javadoc for ProxyLifecycleProvider and move initial ActivityLifec…
math1man Oct 28, 2020
85e592e
Merge remote-tracking branch 'origin/master'
math1man Oct 28, 2020
df2345d
Remove LifecycleProvider as an interface of GoogleMapsPlugin and inst…
math1man Oct 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update CHANGELOG.md and version
  • Loading branch information
@math1man
math1man committed Oct 27, 2020
commit e934a18b284d44bd3fec6098c3ac1dcbc91c7a3a
10 changes: 10 additions & 0 deletions packages/google_maps_flutter/google_maps_flutter/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,13 @@
## 1.1.0
Copy link
Contributor

@amirh amirh Oct 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't introduce new features so should be a patch bump (1.0.5)

Copy link
Contributor Author

@math1man math1man Oct 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


Overhaul lifecycle management in GoogleMapsPlugin.

GoogleMapController is now uniformly driven by implementing `DefaultLifecycleObserver`. That observer is registered to a lifecycle from one of three sources:

1. For v2 plugin registration, `GoogleMapsPlugin` obtains the lifecycle via `ActivityAware` methods.
2. For v1 plugin registration, if the activity implements `LifecycleOwner`, it's lifecycle is used directly.
3. For v1 plugin registration, if the activity does not implement `LifecycleOwner`, a proxy lifecycle is created and driven via `ActivityLifecycleCallbacks`.

## 1.0.4

* Cleanup of Android code:
Expand Down
2 changes: 1 addition & 1 deletion packages/google_maps_flutter/google_maps_flutter/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: google_maps_flutter
description: A Flutter plugin for integrating Google Maps in iOS and Android applications.
homepage: https://github.com/flutter/plugins/tree/master/packages/google_maps_flutter/google_maps_flutter
version: 1.0.4
version: 1.1.0
Copy link
Contributor

@amirh amirh Oct 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget to update the version here as well

Copy link
Contributor Author

@math1man math1man Oct 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


dependencies:
flutter:
Expand Down