Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[in_app_purchase] Added serviceTimeout code #3287

Merged
fluttergithubbot merged 8 commits into from
Jan 7, 2021
Merged

[in_app_purchase] Added serviceTimeout code #3287

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6f7ea34
Added a failing test case (for enum value -3)
impure Nov 24, 2020
ce8b70d
Added the changes from NikitaZhelonkin. Appears to fix the issue.
impure Nov 24, 2020
1d5054d
This should be a /// not a //
impure Nov 24, 2020
f93970b
What the heck? Let's add all the other billing responses too.
impure Nov 24, 2020
4c5ccea
Tabs to spaces
impure Nov 24, 2020
792a3ac
Upped version number and added changelog
impure Nov 24, 2020
e7ce46d
Merged these tests into a single test
impure Nov 30, 2020
879fc36
Changed version from 0.3.4+17 to 0.3.5
impure Dec 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Added a failing test case (for enum value -3)
  • Loading branch information
@impure
impure committed Dec 21, 2020
commit 6f7ea347ee64aa7047d2b668ef9158587426fc55
9 changes: 9 additions & 0 deletions packages/in_app_purchase/test/billing_client_wrappers/billing_client_wrapper_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,15 @@ void main() {
});
});

// Make sure that the enum values are supported and that the converter call
// does not fail
group('enumValues', () {
test('enum -3', () async {
BillingResponseConverter converter = BillingResponseConverter();
converter.fromJson(-3);
Copy link
Contributor

@mklim mklim Nov 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Could you combine these different assertions into one test? These are different statements, but it's really testing that all the expected values are supported. So I think it makes sense to put them in one test case instead of having one per enum value.

Copy link
Contributor Author

@impure impure Dec 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, done.

});
});

group('startConnection', () {
final String methodName =
'BillingClient#startConnection(BillingClientStateListener)';
Expand Down