Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Exclude null-safe plugins from testing on stable #3318

Merged
blasten merged 5 commits into from
Dec 11, 2020
Merged

Exclude null-safe plugins from testing on stable #3318

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7cf970b
Exclude nnbd plugins from testing on stable
Dec 10, 2020
96e5f11
;
Dec 10, 2020
33525ff
Add debugging info
Dec 10, 2020
888fa34
Retrigger
Dec 11, 2020
69bfc6a
Merge branch 'master' into exclude_nnbd_plugins
Dec 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add debugging info
  • Loading branch information
Emmanuel Garcia committed Dec 10, 2020
commit 33525ff9a4ebd4757df9a7272896f6d2f2c057e8
2 changes: 2 additions & 0 deletions script/build_all_plugins_app.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ if [[ "$CHANNEL" -eq "stable" ]]; then
ALL_EXCLUDED=("$EXCLUDED,$EXCLUDED_PLUGINS_FROM_STABLE")
fi

echo "Excluding the following plugins: $ALL_EXCLUDED"

(cd "$REPO_DIR" && pub global run flutter_plugin_tools all-plugins-app --exclude $ALL_EXCLUDED)

function error() {
Expand Down
1 change: 1 addition & 0 deletions script/incremental_build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ ALL_EXCLUDED=("")
# Exclude nnbd plugins from stable.
if [[ "$CHANNEL" -eq "stable" ]]; then
ALL_EXCLUDED=($EXCLUDED_PLUGINS_FROM_STABLE)
Copy link
Contributor

@amirh amirh Dec 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can you print to the log here that we're skipping checks for the following plugins?

Copy link
Author

@blasten blasten Dec 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

echo "Excluding the following plugins: $ALL_EXCLUDED"
fi

# Plugins that deliberately use their own analysis_options.yaml.
Expand Down