Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Fix test exclusion logic for nnbd plugins #3342

Merged
blasten merged 15 commits into from
Dec 20, 2020
Merged

Fix test exclusion logic for nnbd plugins #3342

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
16d759e
fix the nnbd plugin test exclusion logic
amirh Dec 17, 2020
26ae34f
Fix analyzer
Dec 17, 2020
437a2d3
Fixes
Dec 17, 2020
a15bffe
Exclude local_auth from build all plugins
Dec 17, 2020
3c9b9ae
nits
Dec 17, 2020
3b421db
[localauth] Rename file
Dec 17, 2020
9a1aaaa
Use right channel
Dec 17, 2020
32260b0
macos isn't supported on stable
Dec 18, 2020
6997fc3
Merge branch 'master' into fix_exclude
Dec 18, 2020
64a7137
Disable test
Dec 18, 2020
dd2470e
Merge branch 'master' into fix_exclude
Dec 18, 2020
a1a9918
Skip another failing test
Dec 18, 2020
6a20c4e
[webview_flutter] Fix `onWebResourceError` on iOS
Dec 20, 2020
301a76f
Merge branch 'master' into fix_exclude
Dec 20, 2020
f68a2e9
Remove Flutter.podspec
Dec 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixes
  • Loading branch information
Emmanuel Garcia committed Dec 17, 2020
commit 437a2d317766c1283f288d81c04edddf8cdfa477
1 change: 0 additions & 1 deletion packages/video_player/video_player/example/integration_test/video_player_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.


// TODO(amirh): Remove this once flutter_driver supports null safety.
// https://github.com/flutter/flutter/issues/71379
// @dart = 2.9
Expand Down
8 changes: 6 additions & 2 deletions packages/webview_flutter/example/integration_test/webview_flutter_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

// @dart = 2.9

import 'dart:async';
import 'dart:convert';
import 'dart:io';
Expand Down Expand Up @@ -416,7 +418,8 @@ void main() {
expect(isPaused, _webviewBool(true));
});

testWidgets('Changes to initialMediaPlaybackPolicy are ignored', (WidgetTester tester) async {
testWidgets('Changes to initialMediaPlaybackPolicy are ignored',
(WidgetTester tester) async {
final Completer<WebViewController> controllerCompleter =
Completer<WebViewController>();
Completer<void> pageLoaded = Completer<void>();
Expand Down Expand Up @@ -474,7 +477,8 @@ void main() {
expect(isPaused, _webviewBool(false));
});

testWidgets('Video plays inline when allowsInlineMediaPlayback is true', (WidgetTester tester) async {
testWidgets('Video plays inline when allowsInlineMediaPlayback is true',
(WidgetTester tester) async {
Completer<WebViewController> controllerCompleter =
Completer<WebViewController>();
Completer<void> pageLoaded = Completer<void>();
Expand Down
16 changes: 8 additions & 8 deletions packages/webview_flutter/example/lib/main.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ class _WebViewExampleState extends State<WebViewExample> {
if (controller.hasData) {
return FloatingActionButton(
onPressed: () async {
final String url = await controller.data.currentUrl();
final String url = (await controller.data!.currentUrl())!;
// ignore: deprecated_member_use
Scaffold.of(context).showSnackBar(
SnackBar(content: Text('Favorited $url')),
Expand Down Expand Up @@ -145,25 +145,25 @@ class SampleMenu extends StatelessWidget {
onSelected: (MenuOptions value) {
switch (value) {
case MenuOptions.showUserAgent:
_onShowUserAgent(controller.data, context);
_onShowUserAgent(controller.data!, context);
break;
case MenuOptions.listCookies:
_onListCookies(controller.data, context);
_onListCookies(controller.data!, context);
break;
case MenuOptions.clearCookies:
_onClearCookies(context);
break;
case MenuOptions.addToCache:
_onAddToCache(controller.data, context);
_onAddToCache(controller.data!, context);
break;
case MenuOptions.listCache:
_onListCache(controller.data, context);
_onListCache(controller.data!, context);
break;
case MenuOptions.clearCache:
_onClearCache(controller.data, context);
_onClearCache(controller.data!, context);
break;
case MenuOptions.navigationDelegate:
_onNavigationDelegateExample(controller.data, context);
_onNavigationDelegateExample(controller.data!, context);
break;
}
},
Expand Down Expand Up @@ -299,7 +299,7 @@ class NavigationControls extends StatelessWidget {
(BuildContext context, AsyncSnapshot<WebViewController> snapshot) {
final bool webViewReady =
snapshot.connectionState == ConnectionState.done;
final WebViewController controller = snapshot.data;
final WebViewController controller = snapshot.data!;
return Row(
children: <Widget>[
IconButton(
Expand Down
2 changes: 2 additions & 0 deletions packages/webview_flutter/example/test_driver/integration_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

// @dart = 2.9

import 'dart:async';
import 'dart:convert';
import 'dart:io';
Expand Down