Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[ios_platform_images] Migrate to null safety #3381

Merged
bparrishMines merged 11 commits into from
Feb 8, 2021
+41 −19
Merged

[ios_platform_images] Migrate to null safety #3381

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d1c7f2f
migrate to null safety
bparrishMines Dec 28, 2020
0f6f1b8
Merge branch 'master' of github.com:flutter/plugins into ios_platform…
bparrishMines Dec 30, 2020
7e9810e
bump versions
bparrishMines Dec 30, 2020
1add87f
add to nnbd plugins
bparrishMines Dec 30, 2020
24fec68
return nullable string
bparrishMines Dec 30, 2020
95cb229
not necessary to use ?
bparrishMines Dec 30, 2020
39356a6
use min dependencies
bparrishMines Jan 7, 2021
ce2fa40
comple with error on null map
bparrishMines Jan 12, 2021
b6025ff
revert example and use named parameters
bparrishMines Feb 8, 2021
abee4eb
Merge branch 'master' of github.com:flutter/plugins into ios_platform…
bparrishMines Feb 8, 2021
cd5299c
fix main.dart
bparrishMines Feb 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
not necessary to use ?
  • Loading branch information
@bparrishMines
bparrishMines committed Dec 30, 2020
commit 95cb22993ea682fd910777debb56576e4ed65509
2 changes: 1 addition & 1 deletion packages/ios_platform_images/lib/ios_platform_images.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,6 @@ class IosPlatformImages {
///
/// See [https://developer.apple.com/documentation/foundation/nsbundle/1411540-urlforresource?language=objc]
static Future<String?> resolveURL(String name, [String? ext]) {
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g Feb 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're doing breaking changes anyway, and optional positional elements are strongly discouraged, should we take the opportunity to make this {String? extension}?

Copy link

@blasten blasten Feb 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

return _channel.invokeMethod<String?>('resolveURL', [name, ext]);
return _channel.invokeMethod<String>('resolveURL', [name, ext]);
}
}