Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[url_launcher] Update result to True when the url was loaded successfully. #3475

Merged
lidongze91 merged 8 commits into from
Feb 24, 2021
Merged

[url_launcher] Update result to True when the url was loaded successfully. #3475

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
31a712e
Update FLTURLLauncherPlugin.m
lidongze91 Jan 28, 2021
6079602
Merge branch 'lidongze91-patch-1' of github.com:lidongze91/plugins in…
Feb 22, 2021
950140c
Update pubspec.yaml
lidongze91 Feb 22, 2021
15e3bf9
Update CHANGELOG.md
lidongze91 Feb 22, 2021
c70cf67
Merge branch 'master' into lidongze91-patch-1
lidongze91 Feb 22, 2021
2086a69
Merge branch 'master' of github.com:flutter/plugins into lidongze91-p…
Feb 23, 2021
bc94a51
fix conflict
Feb 23, 2021
eb386b9
Undo the re-addition of pre-release changelogs.
stuartmorgan Feb 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Update FLTURLLauncherPlugin.m 
Update result to `True` when the url was loaded successfully.
  • Loading branch information
@lidongze91
lidongze91 authored Jan 28, 2021
commit 31a712e1a9f5c9a1e0bf4a38d00143b33ec438e3
2 changes: 1 addition & 1 deletion packages/url_launcher/url_launcher/ios/Classes/FLTURLLauncherPlugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ - (instancetype)initWithUrl:url withFlutterResult:result {
- (void)safariViewController:(SFSafariViewController *)controller
didCompleteInitialLoad:(BOOL)didLoadSuccessfully API_AVAILABLE(ios(9.0)) {
if (didLoadSuccessfully) {
self.flutterResult(nil);
self.flutterResult(@YES);
} else {
self.flutterResult([FlutterError
errorWithCode:@"Error"
Expand Down