Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[camera_platform_interface] Migrate to null safety #3497

Merged
mvanbeusekom merged 15 commits into from
Feb 8, 2021
Merged

[camera_platform_interface] Migrate to null safety #3497

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
7c4e187
Migrate camera_platform_interface to null safety
mvanbeusekom Feb 2, 2021
bf94a5d
Added camera to the NNBD plugin list
mvanbeusekom Feb 2, 2021
c56c8c2
Correct version number
mvanbeusekom Feb 3, 2021
4fbbfd0
Convert optional parameters to required for CameraInitializationEvent
mvanbeusekom Feb 3, 2021
d3e86f1
Convert CameraId in test to non-nullable
mvanbeusekom Feb 3, 2021
025bc8d
Test for null instead of enforcing non-null
mvanbeusekom Feb 4, 2021
7f3db23
Attempt to fix dependency problem building all plugins
mvanbeusekom Feb 5, 2021
a8d251f
Mark google_maps_flutter as NNBD
mvanbeusekom Feb 5, 2021
cb539d5
Depend on correct Dart SDK version
mvanbeusekom Feb 6, 2021
d9d3271
Attempt to fix dependency problem building all plugins
mvanbeusekom Feb 6, 2021
e6e29b5
Attempt to fix dependency problem building all plugins
mvanbeusekom Feb 6, 2021
5e1f271
Attempt to fix dependency problem building all plugins
mvanbeusekom Feb 6, 2021
b4157dd
Attempt to fix dependency problem building all plugins
mvanbeusekom Feb 6, 2021
119c9cb
Add camera_platform_interface to exclude list
mvanbeusekom Feb 8, 2021
051b6a0
Exclude camera from nnbd and non-nnbd
mvanbeusekom Feb 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Exclude camera from nnbd and non-nnbd
  • Loading branch information
@mvanbeusekom
mvanbeusekom committed Feb 8, 2021
commit 051b6a04cb0c4e699dd145d567d719993649730f
1 change: 0 additions & 1 deletion script/build_all_plugins_app.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ source "$SCRIPT_DIR/nnbd_plugins.sh"
check_changed_packages > /dev/null

readonly EXCLUDED_PLUGINS_LIST=(
"camera_platform_interface"
"connectivity_macos"
"connectivity_platform_interface"
"connectivity_web"
Expand Down
2 changes: 1 addition & 1 deletion script/nnbd_plugins.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
readonly NNBD_PLUGINS_LIST=(
"android_intent"
"battery"
"camera_platform_interface"
"camera"
Copy link
Member

@ditman ditman Feb 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, remove "camera" from the NON_NNBD_PLUGINS_LIST below. Otherwise this plugin won't be tested neither in master, nor stable :)

Copy link
Contributor

@bparrishMines bparrishMines Feb 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested this to fix the failing build_all_plugins test. camera has a conflict with google_sign_in while camera_platform_interface has a conflict with google_maps_flutter. I suggested that we keep them excluded from both until the camera plugin is migrated.

The alternative to this would be to remove the camera plugin from the build_all_plugins test and run the camera tests on master. Would that be alright?

Copy link
Member

@ditman ditman Feb 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh, I see! As this is right now, build_all_plugins is already not building the camera plugin, right? As long as some 'camera' tests run in some shard in master, it's probably enough!

"connectivity"
"cross_file"
"device_info"
Expand Down