Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[shared_preferences_windows]-Migrate to null safety #3516

Merged
stuartmorgan-g merged 6 commits into from
Feb 8, 2021
Merged

[shared_preferences_windows]-Migrate to null safety #3516

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a21504f
migrate to null safety
sameeerkashyap Feb 5, 2021
e7a56f0
added formatting
sameeerkashyap Feb 5, 2021
18c20fd
Merge branch 'master' into shared_preferences/null-safety-windows
sameeerkashyap Feb 5, 2021
3c5f834
resolved issues
sameeerkashyap Feb 6, 2021
5728f0e
fixed fotmatting
sameeerkashyap Feb 6, 2021
9ee0b1d
More review fixes
stuartmorgan-g Feb 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' into shared_preferences/null-safety-windows
  • Loading branch information
@sameeerkashyap
sameeerkashyap authored Feb 5, 2021
commit 18c20fd62055d0a33b1d716dc19f38cfa8f220cb
5 changes: 5 additions & 0 deletions packages/shared_preferences/shared_preferences_windows/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@

## 0.0.3-nullsafety

* Migrate to null-safety.

## 0.0.2+3

* Remove 'ffi' dependency.

## 0.0.2+2

* Relax 'ffi' version constraint.
Expand Down
2 changes: 2 additions & 0 deletions packages/shared_preferences/shared_preferences_windows/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ description: Windows implementation of shared_preferences
homepage: https://github.com/flutter/plugins/tree/master/packages/shared_preferences/shared_preferences_windows
version: 0.0.3-nullsafety


flutter:
plugin:
platforms:
Expand All @@ -18,6 +19,7 @@ dependencies:
shared_preferences_platform_interface: ^2.0.0-nullsafety
flutter:
sdk: flutter

ffi: ^0.2.0-nullsafety.1
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g Feb 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was removed intentionally, and shouldn't be re-added.

Copy link
Contributor Author

@sameeerkashyap sameeerkashyap Feb 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if I understand which one are you referring to?

file: ^6.0.0-nullsafety.4
meta: ^1.1.7
Expand Down
1 change: 1 addition & 0 deletions script/nnbd_plugins.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ readonly NNBD_PLUGINS_LIST=(
"video_player"
"webview_flutter"
"shared_preferences_windows"
"image_picker"
)

# This list contains the list of plugins that have *not* been
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.