Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[url_launcher_web] Migrate to null-safety #3522

Merged
ditman merged 21 commits into from
Feb 16, 2021
Merged

[url_launcher_web] Migrate to null-safety #3522

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
46a4b23
Add null safety to web implementation
mvanbeusekom Oct 20, 2020
ac7429c
Migrate Link to null safety, and update pubspec.yaml
ditman Feb 3, 2021
01bde66
Migrate test to null safety, and update pubspec.yaml (WIP)
ditman Feb 3, 2021
5c9910f
Split LinkWidget tests from plugin tests.
ditman Feb 3, 2021
3a9e3d8
Codegen mocks
ditman Feb 6, 2021
ddd7020
Fix changelog version.
ditman Feb 6, 2021
04d0f55
Add back ignored file, so analyzer doesn't complain about it not exis…
ditman Feb 9, 2021
ffaf7d7
dartfmt -w .
ditman Feb 9, 2021
c4c9fd4
Manual changes to generated mocks for analyzer to pass.
ditman Feb 9, 2021
c24337f
Revert "Manual changes to generated mocks for analyzer to pass."
ditman Feb 10, 2021
272079e
Rename 'test' to 'example'
ditman Feb 10, 2021
69fbf42
Exclude Mockito5 mocks from analysis.
ditman Feb 10, 2021
75d4fec
Improve example docs to describe how tests are run better.
ditman Feb 10, 2021
4ac7cd9
Add a test directory to point users to the correct tests inside the e…
ditman Feb 10, 2021
ed38b18
Restore url_launcher pubspec.
ditman Feb 10, 2021
7b611c7
pubspec cleanup
ditman Feb 10, 2021
a5e0953
Having a null 'uri' is valid.
ditman Feb 11, 2021
3d8a706
Use non-preview versions of null-safe deps.
ditman Feb 12, 2021
69c7db1
Rename run_test to run_test.sh, update docs. Point users to README.md…
ditman Feb 12, 2021
05433db
Make the package usable and endorseable in the next stable release.
ditman Feb 12, 2021
bb58825
Use default mocks.
ditman Feb 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Exclude Mockito5 mocks from analysis.
  • Loading branch information
@ditman
ditman committed Feb 10, 2021
commit 69fbf42462c879438959ea8a65ce2e5d98941ecb
1 change: 1 addition & 0 deletions analysis_options.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ analyzer:
# Ignore generated files
- '**/*.g.dart'
- 'lib/src/generated/*.dart'
- '**/*.mocks.dart' # Mockito @GenerateMocks
Copy link

@blasten blasten Feb 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👏

errors:
always_require_non_null_named_parameters: false # not needed with nnbd
unnecessary_null_comparison: false # Turned as long as nnbd mix-mode is supported.
Expand Down