Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Cleanup and regularization
  • Loading branch information
stuartmorgan-g committed Feb 17, 2021
commit f9686051039fb8cb1a9c0718f96e3ceeb6b4b2a0
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// Copyright 2019, the Chromium project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

// @dart=2.9

import 'dart:async';
Expand Down
2 changes: 1 addition & 1 deletion packages/path_provider/path_provider/example/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,5 @@ flutter:
uses-material-design: true

environment:
sdk: '>=2.12.0 <3.0.0'
sdk: ">=2.12.0-0 <3.0.0"
flutter: ">=1.12.13+hotfix.5"
42 changes: 1 addition & 41 deletions packages/path_provider/path_provider_linux/example/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,12 @@ publish_to: "none"

environment:
sdk: ">=2.12.0-0 <3.0.0"
flutter: ">=1.10.0"

dependencies:
flutter:
sdk: flutter

path_provider_linux: any

# The following adds the Cupertino Icons font to your application.
# Use with the CupertinoIcons class for iOS style icons.
cupertino_icons: ^0.1.3

dependency_overrides:
path_provider_linux:
# When depending on this package from a real application you should use:
# path_provider_linux: ^x.y.z
Expand All @@ -32,39 +26,5 @@ dev_dependencies:
integration_test:
path: ../../../integration_test

# For information on the generic Dart part of this file, see the
# following page: https://dart.dev/tools/pub/pubspec

# The following section is specific to Flutter.
flutter:
# The following line ensures that the Material Icons font is
# included with your application, so that you can use the icons in
# the material Icons class.
uses-material-design: true
# To add assets to your application, add an assets section, like this:
# assets:
# - images/a_dot_burr.jpeg
# - images/a_dot_ham.jpeg
# An image asset can refer to one or more resolution-specific "variants", see
# https://flutter.dev/assets-and-images/#resolution-aware.
# For details regarding adding assets from package dependencies, see
# https://flutter.dev/assets-and-images/#from-packages
# To add custom fonts to your application, add a fonts section here,
# in this "flutter" section. Each entry in this list should have a
# "family" key with the font family name, and a "fonts" key with a
# list giving the asset and other descriptors for the font. For
# example:
# fonts:
# - family: Schyler
# fonts:
# - asset: fonts/Schyler-Regular.ttf
# - asset: fonts/Schyler-Italic.ttf
# style: italic
# - family: Trajan Pro
# fonts:
# - asset: fonts/TrajanPro.ttf
# - asset: fonts/TrajanPro_Bold.ttf
# weight: 700
#
# For details regarding fonts from package dependencies,
# see https://flutter.dev/custom-fonts/#from-packages
Original file line number Diff line number Diff line change
Expand Up @@ -4,19 +4,14 @@ description: Demonstrates how to use the path_provider plugin.
dependencies:
flutter:
sdk: flutter
path_provider_macos: any
path_provider_platform_interface: 2.0.0-nullsafety

# path_provider_macos is endorsed, so we need to add it to dependency_overrides
# to depend on it from path:
dependency_overrides:
path_provider_macos:
# When depending on this package from a real application you should use:
# path_provider_macos: ^x.y.z
# See https://dart.dev/tools/pub/dependencies#version-constraints
# The example app is bundled with the plugin so we use a path dependency on
# the parent directory to use the current plugin's version.
path: ../
path_provider_platform_interface: 2.0.0-nullsafety
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this how folks should use path_provider, or as you mentioned to remove the circular dependency only?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to avoid circular dependencies. If someone really wanted to use a platform interface package instead of an app-facing package that's always something they could do, but in general I don't see why someone would want to.

(example is arguably a bad name for implementation package testbeds... except that in the case of a plugin that has its own platform-specific API extensions, you would use the implementation package directly, and this would be where the examples of that would be, so it's a bit tricky.)


dev_dependencies:
integration_test:
Expand All @@ -29,5 +24,5 @@ flutter:
uses-material-design: true

environment:
sdk: '>=2.12.0 <3.0.0'
sdk: ">=2.12.0-0 <3.0.0"
flutter: ">=1.10.0"
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ description: Demonstrates how to use the path_provider plugin.
dependencies:
flutter:
sdk: flutter
path_provider_windows: any

dependency_overrides:
path_provider_windows:
# When depending on this package from a real application you should use:
# path_provider_windows: ^x.y.z
Expand All @@ -26,5 +23,5 @@ flutter:
uses-material-design: true

environment:
sdk: '>=2.12.0 <3.0.0'
sdk: ">=2.12.0-0 <3.0.0"
flutter: ">=1.12.13+hotfix.4"
2 changes: 1 addition & 1 deletion packages/path_provider/path_provider_windows/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,5 @@ dev_dependencies:
pedantic: ^1.10.0-nullsafety.3

environment:
sdk: '>=2.12.0-259.8.beta <3.0.0'
sdk: ">=2.12.0-0 <3.0.0"
flutter: ">=1.12.13+hotfix.4"