This repository was archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[path_provider] Migrate examples to null-safety #3559
Merged
stuartmorgan-g
merged 12 commits into
flutter:master
from
stuartmorgan-g:path-provider-example-migration
Feb 19, 2021
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
7a6cf46
Migrate path_provider example (not integration test)
stuartmorgan-g 245662f
Rewrite and migrate macOS example
stuartmorgan-g 2a2cd66
Migrate Windows example
stuartmorgan-g edab05f
Migrate Linux example
stuartmorgan-g f968605
Cleanup and regularization
stuartmorgan-g 57808f5
Remove unnecessary async
stuartmorgan-g e0ac577
Merge branch 'master' into path-provider-example-migration
stuartmorgan-g 60bfd3b
Fix Windows integration test
stuartmorgan-g 49253aa
Opt drivers out of strong mode
stuartmorgan-g ef92983
Fix integration tests bugs introduced during the conversion
stuartmorgan-g cb3d0c1
Add missing entitlement to macOS example
stuartmorgan-g 85ca2d6
Work around download validation issue on macOS
stuartmorgan-g File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Cleanup and regularization
- Loading branch information
commit f9686051039fb8cb1a9c0718f96e3ceeb6b4b2a0
There are no files selected for viewing
1 change: 1 addition & 0 deletions
1
packages/path_provider/path_provider/example/integration_test/path_provider_test.dart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this how folks should use path_provider, or as you mentioned to remove the circular dependency only?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to avoid circular dependencies. If someone really wanted to use a platform interface package instead of an app-facing package that's always something they could do, but in general I don't see why someone would want to.
(
exampleis arguably a bad name for implementation package testbeds... except that in the case of a plugin that has its own platform-specific API extensions, you would use the implementation package directly, and this would be where the examples of that would be, so it's a bit tricky.)