Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[quick_action] fix delegate methods not called on iOS #3621

Merged
cyanglaz merged 23 commits into from
Feb 25, 2021
Merged

[quick_action] fix delegate methods not called on iOS #3621

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
3bb2523
quick action stable
Feb 23, 2021
070e8bb
fix ios delegate not caleld
Feb 23, 2021
665c2a8
Merge branch 'master' into nnbd_quick_action
Feb 23, 2021
9c12df9
add tests
Feb 23, 2021
6f49499
remove wrong checkin
Feb 23, 2021
bd29bca
revert
Feb 23, 2021
bb477a8
format
Feb 23, 2021
b58ac63
review'
Feb 23, 2021
e96a091
Update CHANGELOG.md
Feb 23, 2021
8d5612f
add uitest scheme
Feb 23, 2021
641c6bf
add debug code
Feb 24, 2021
3958465
try ios 14.4
Feb 24, 2021
f2cd527
remove other tests
Feb 24, 2021
90e5901
fix ios version
Feb 24, 2021
11c8bc3
test ci with simple launch
Feb 24, 2021
64e02c4
remove quick action code in main.dart
Feb 24, 2021
a37cb34
add meta data files
Feb 24, 2021
3edc158
try remove drive test
Feb 24, 2021
408a658
move drive test after xctest
Feb 24, 2021
1c42b2d
remove unncessary files
Feb 24, 2021
0ae46b6
revert testing code in cirrus script
Feb 24, 2021
99425b8
review
Feb 24, 2021
abf9ce0
rerun ci
Feb 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
review'
  • Loading branch information
Chris Yang committed Feb 23, 2021
commit b58ac6399790bb030881d962b0fc192bb22718cf
1 change: 1 addition & 0 deletions packages/quick_actions/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
## 0.5.0

* Migrate to null safety.
* Fixes quick action not working on iOS.
Copy link
Contributor Author

@cyanglaz cyanglaz Feb 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the review comments, also added this


## 0.4.0+12

Expand Down
2 changes: 1 addition & 1 deletion packages/quick_actions/example/ios/RunnerUITests/RunnerUITests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
#import <XCTest/XCTest.h>
#import <os/log.h>

const int kElementWaitingTime = 30;
static const int kElementWaitingTime = 30;

@interface RunnerUITests : XCTestCase

Expand Down