Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[video_player] Add macOS support #3712

Closed
cbenhagen wants to merge 8 commits into from
Closed

[video_player] Add macOS support #3712

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
13e55fb
[video_player] Add macOS implementation
cbenhagen Mar 10, 2021
2bafdac
Merge branch 'master' into video_player_macos_new
cbenhagen Aug 31, 2021
a0d4dd0
Use integration_test from sdk
cbenhagen Aug 31, 2021
c21c6f3
Do not redraw excessively
cbenhagen Aug 31, 2021
a72e845
Retain buffer
cbenhagen Sep 2, 2021
33f1c9a
Deallocate player and playerItem
cbenhagen Sep 2, 2021
9e9aec7
Notify on seek
cbenhagen Oct 22, 2021
35d8ec2
Return a copy of the last valid frame
cbenhagen Nov 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Retain buffer
  • Loading branch information
@cbenhagen
cbenhagen committed Sep 2, 2021
commit a72e8456633b88cdbd7523a5f696792673a4c37a
3 changes: 3 additions & 0 deletions packages/video_player/video_player_macos/macos/Classes/FLTVideoPlayerPlugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,7 @@ - (void)notifyIfFrameAvailable {
if (!_playerItem || _playerItem.status != AVPlayerItemStatusReadyToPlay || ![_videoOutput hasNewPixelBufferForItemTime:outputItemTime]) {
return;
} else {
CVBufferRelease(_frame);
_frame = [_videoOutput copyPixelBufferForItemTime:outputItemTime itemTimeForDisplay:NULL];
if (_frame == NULL) {
NSLog(@"copyPixelBufferForItemTime returned NULL");
Expand Down Expand Up @@ -440,6 +441,7 @@ - (CVPixelBufferRef)copyPixelBuffer {
if (_frame == NULL) {
NSLog(@"Returning NULL from copyPixelBuffer");
}
CVBufferRetain(_frame);
return _frame;
}

Expand Down Expand Up @@ -471,6 +473,7 @@ - (FlutterError* _Nullable)onListenWithArguments:(id _Nullable)arguments
/// so the channel is going to die or is already dead.
- (void)disposeSansEventChannel {
_disposed = true;
CVBufferRelease(_frame);
[self stopDisplayLink];
[[_player currentItem] removeObserver:self forKeyPath:@"status" context:statusContext];
[[_player currentItem] removeObserver:self
Expand Down