Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@Perfetto2020
Copy link

The picture taken from the front camera is mirrored as described in #27650 This change will fix it.

Fixes #27650

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla
Copy link

google-cla bot commented Mar 16, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@Perfetto2020
Copy link
Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Mar 16, 2021
@stuartmorgan-g
Copy link
Contributor

Thanks for the submission! We’re currently working through a large backlog of PRs, and this will require non-trivial review, so it will take some time before we’re able to review it. As explained in CONTRIBUTING.md, votes for the corresponding issue are the primary way we’re prioritizing non-trivial reviews, so we encourage anyone interested in this PR to vote for the corresponding issue.

@nt4f04uNd
Copy link
Member

@Perfetto2020 this should be a tweakable parameter, if you look closesly at the issue you linked this is what its author requesting for

@Perfetto2020
Copy link
Author

@Perfetto2020 this should be a tweakable parameter, if you look closesly at the issue you linked this is what its author requesting for

cannot agree more. make it opt-in later.

@tjcampanella
Copy link

Any status on this?

@bparrishMines bparrishMines removed their request for review August 5, 2021 19:01
@iqtedar123
Copy link

Would love this! :)

@Zazo032
Copy link
Contributor

Zazo032 commented Sep 16, 2021

@Perfetto2020 could you fix the conflicts, please?

@stuartmorgan-g
Copy link
Contributor

Per discussion in #4420, it's not clear that this is the approach we want to take. (And we should certainly be consistent between iOS and Android about how we handle mirroring.)

It's also not clear to me from the diff what exactly the effect of this PR is. Are you completely disabling mirroring, including for the preview?

@godofredoc godofredoc changed the base branch from master to main January 6, 2022 23:00
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@stuartmorgan-g
Copy link
Contributor

It's also not clear to me from the diff what exactly the effect of this PR is. Are you completely disabling mirroring, including for the preview?

Thank you for your contribution. I'm going to close this PR for now since there are outstanding comments, just to get this off our PR review queue. Please don't hesitate to submit a new PR if you have the time to address the review comments. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[camera] Allow controlling the preview and output mirroring

7 participants