-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[camera] Don't mirror the picture taken from front facing lens #3716
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
Thanks for the submission! We’re currently working through a large backlog of PRs, and this will require non-trivial review, so it will take some time before we’re able to review it. As explained in CONTRIBUTING.md, votes for the corresponding issue are the primary way we’re prioritizing non-trivial reviews, so we encourage anyone interested in this PR to vote for the corresponding issue. |
|
@Perfetto2020 this should be a tweakable parameter, if you look closesly at the issue you linked this is what its author requesting for |
cannot agree more. make it opt-in later. |
|
Any status on this? |
|
Would love this! :) |
|
@Perfetto2020 could you fix the conflicts, please? |
|
Per discussion in #4420, it's not clear that this is the approach we want to take. (And we should certainly be consistent between iOS and Android about how we handle mirroring.) It's also not clear to me from the diff what exactly the effect of this PR is. Are you completely disabling mirroring, including for the preview? |
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Thank you for your contribution. I'm going to close this PR for now since there are outstanding comments, just to get this off our PR review queue. Please don't hesitate to submit a new PR if you have the time to address the review comments. Thanks! |
The picture taken from the front camera is mirrored as described in #27650 This change will fix it.
Fixes #27650
Pre-launch Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.