review

script/tool/lib/src/publish_plugin_command.dart

@@ -215,7 +215,7 @@ class PublishPluginCommand extends PluginCommand {
     }
     if (packagesFailed.isNotEmpty) {
       _print(
-          'Packages failed to release: ${packagesFailed.join(', ')}, see above for details.');
+          'Failed to release the following packages: ${packagesFailed.join(', ')}, see above for details.');
     }
     return packagesFailed.isEmpty;
   }
@@ -247,7 +247,7 @@ class PublishPluginCommand extends PluginCommand {
     return true;
   }
 
-  // Returns `true` if needs to release the version, `false` if needs to skip
+  // Returns a [_CheckNeedsReleaseResult] that indicates the result.
   Future<_CheckNeedsReleaseResult> _checkNeedsRelease({
     @required File pubspecFile,
     @required GitVersionFinder gitVersionFinder,
@@ -267,9 +267,7 @@ Safe to ignore if the package is deleted in this commit.
     }
 
     if (pubspec.version == null) {
-      _print('No version found. A package that '
-          'intentionally has no version should be marked '
-          '"publish_to: none".');
+      _print('No version found. A package that intentionally has no version should be marked "publish_to: none"');
       return _CheckNeedsReleaseResult.failure;
     }
 
@@ -484,6 +482,6 @@ enum _CheckNeedsReleaseResult {
   // The package does not need to be released.
   noRelease,
 
-  // There's an error when trying to access if the package needs to be released.
+  // There's an error when trying to determine whether the package needs to be released.
   failure,
 }

script/tool/test/util.dart

@@ -87,14 +87,14 @@ Directory createFakePlugin(
     final Directory exampleDir = pluginDirectory.childDirectory('example')
       ..createSync();
     createFakePubspec(exampleDir,
-        name: '${name}_example', isFlutter: isFlutter, includeVersion: false, publish_to: 'none');
+        name: '${name}_example', isFlutter: isFlutter, includeVersion: false, publishTo: 'none');
   } else if (withExamples.isNotEmpty) {
     final Directory exampleDir = pluginDirectory.childDirectory('example')
       ..createSync();
     for (final String example in withExamples) {
       final Directory currentExample = exampleDir.childDirectory(example)
         ..createSync();
-      createFakePubspec(currentExample, name: example, isFlutter: isFlutter, includeVersion: false, publish_to: 'none');
+      createFakePubspec(currentExample, name: example, isFlutter: isFlutter, includeVersion: false, publishTo: 'none');
     }
   }
 
@@ -125,7 +125,7 @@ void createFakePubspec(
   bool isLinuxPlugin = false,
   bool isMacOsPlugin = false,
   bool isWindowsPlugin = false,
-  String publish_to = 'http://no_pub_server.com',
+  String publishTo = 'http://no_pub_server.com',
   String version = '0.0.1',
 }) {
   parent.childFile('pubspec.yaml').createSync();
@@ -185,9 +185,9 @@ dependencies:
 version: $version
 ''';
   }
-  if (publish_to.isNotEmpty) {
+  if (publishTo.isNotEmpty) {
      yaml += '''
-publish_to: $publish_to # Hardcoded safeguard to prevent this from somehow being published by a broken test.
+publish_to: $publishTo # Hardcoded safeguard to prevent this from somehow being published by a broken test.
 ''';
   }
   parent.childFile('pubspec.yaml').writeAsStringSync(yaml);