Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[in_app_purchase] platform interface improvement #3821

Merged
cyanglaz merged 10 commits into from
May 10, 2021
Merged

[in_app_purchase] platform interface improvement #3821

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
674bddd
platform interface improvement
Apr 22, 2021
875d3f1
format
Apr 22, 2021
06daea2
review
Apr 23, 2021
7f1653f
review
May 3, 2021
0f3d0b9
update docs
May 3, 2021
899bafb
asert and test
May 3, 2021
8a7341d
tupo
May 3, 2021
a697f09
fix analyzer errors
May 4, 2021
b8774b6
review
May 5, 2021
2d9c2ae
Merge branch 'master' into iap_platform_interface
May 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update docs
  • Loading branch information
Chris Yang committed May 3, 2021
commit 0f3d0b9728c1220370e3b50c70ac619fbd836dd3
4 changes: 3 additions & 1 deletion ...urchase/in_app_purchase_platform_interface/lib/src/in_app_purchase_platform_addition.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@ import 'package:plugin_platform_interface/plugin_platform_interface.dart';
/// a class that either extend or implements [InAppPurchasePlatformAddition]. Then replace
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g May 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/replace ... with/set ... to/ (by default there's no instance, so there's nothing to replace)

Copy link
Contributor Author

@cyanglaz cyanglaz May 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

/// the [InAppPurchasePlatformAddition.instance] with an instance of that class.
///
/// We highly recommand against to have [InAppPurchasePlatformAddition] and [InAppPurchasePlatform]
/// All the APIs added by [InAppPurchasePlatformAddition] implementers will be accessed from
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g May 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/implementers/implementations/

Copy link
Contributor Author

@cyanglaz cyanglaz May 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

/// [InAppPurchasePlatformAdditionProvider.getPlatformAddition] by the client APPs.
/// To avoid client APPs to directly call the [InAppPurchasePlatform] APIs, we highly recommand to not have [InAppPurchasePlatformAddition] and [InAppPurchasePlatform]
/// being the same class.
abstract class InAppPurchasePlatformAddition {
/// The instance containing the platform-specific in_app_purchase
Expand Down