Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[camera] Run iOS methods on UI thread by default #4140

Merged
merged 40 commits into from
Oct 20, 2021
Merged

[camera] Run iOS methods on UI thread by default #4140

Changes from 1 commit
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
dea50fc
Only run `initWithCameraName` on background thread.
renefloor Jul 7, 2021
da83b51
run camera start async
renefloor Jul 7, 2021
277d923
Start with migrating to ThreadSafeFlutterResult
renefloor Jul 8, 2021
9bd75bd
Migrated all results to thread safe class
renefloor Jul 9, 2021
a079af9
make data nonNullable
renefloor Jul 9, 2021
bd7d8eb
copyright
renefloor Jul 9, 2021
f0a2bb0
Merge remote-tracking branch 'flutter/master' into bugfix/camera-thre…
renefloor Jul 9, 2021
4125244
Added method channel tests
renefloor Jul 12, 2021
71e321e
Extend unit test
renefloor Jul 13, 2021
bdfde1a
replace dispatch loop with notifications
renefloor Jul 13, 2021
e6b848c
Made test much cleaner
renefloor Jul 13, 2021
d59a80d
add return for error
renefloor Jul 13, 2021
0f35095
changelog and pubspec
renefloor Jul 13, 2021
0b63dea
Add documentation
renefloor Jul 13, 2021
8bc557f
Merge branch 'master' into bugfix/camera-threading
renefloor Jul 13, 2021
b53ab3e
Make interface an extension
renefloor Jul 14, 2021
b6acf82
Increase timeout
renefloor Jul 14, 2021
9f31156
Merge remote-tracking branch 'flutter/master' into bugfix/camera-thre…
renefloor Aug 16, 2021
a4cf79e
update broken test
renefloor Aug 16, 2021
2b84db2
Documentation improvements
renefloor Aug 16, 2021
92c2d00
Make result methods verbs
renefloor Aug 16, 2021
2722cf4
small doc changes
renefloor Aug 16, 2021
4a1155a
remove notification center
renefloor Aug 17, 2021
04566ae
Added unit test for thread safe result
renefloor Aug 17, 2021
57c63ae
add extra comment
renefloor Aug 17, 2021
5c69728
Merge branch 'master' of https://github.com/flutter/plugins into bugf…
mvanbeusekom Oct 8, 2021
e2ba654
Revert removing handleMethodCallAsync.
mvanbeusekom Oct 8, 2021
17d1f5d
Fix unit tests
mvanbeusekom Oct 11, 2021
a0be148
Merge remote-tracking branch 'upstream/master' into bugfix/camera-thr…
mvanbeusekom Oct 11, 2021
ee453bc
Removed left over GIT merge tag
mvanbeusekom Oct 14, 2021
cd48ddd
Applied feedback on PR
mvanbeusekom Oct 14, 2021
98fe08a
Merge remote-tracking branch 'upstream/master' into bugfix/camera-thr…
mvanbeusekom Oct 14, 2021
a4e5262
Remove development team from project file
mvanbeusekom Oct 14, 2021
39d1438
Remove custom setting from XCScheme
mvanbeusekom Oct 14, 2021
3a12cbf
Clean up mock
mvanbeusekom Oct 14, 2021
8e8bdfc
Clean reference to CameraPlugin
mvanbeusekom Oct 14, 2021
3e86910
Apply feedback from PR.
mvanbeusekom Oct 18, 2021
9093887
Merge remote-tracking branch 'upstream/master' into bugfix/camera-thr…
mvanbeusekom Oct 18, 2021
1d51203
Apply review feedback.
mvanbeusekom Oct 18, 2021
f0b9f53
Merge remote-tracking branch 'upstream/master' into bugfix/camera-thr…
mvanbeusekom Oct 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clean reference to CameraPlugin
  • Loading branch information
@mvanbeusekom
mvanbeusekom committed Oct 14, 2021
commit 8e8bdfc71969bfacb0d8aeb1c743fb7af538d3f7
2 changes: 1 addition & 1 deletion packages/camera/camera/example/ios/RunnerTests/CameraOrientationTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ - (void)setUp {
}

- (void)tearDown {
[self.mockMessenger stopMocking];
self.mockMessenger = nil;
self.cameraPlugin = nil;
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g Oct 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would actually much rather the ivars, the setup, and the teardown all be removed, and those two lines move into the test. Per the article I linked in a recent PR comment, stateless fixtures >> stateful fixtures, and in this case we're only saving two lines of boilerplate (assuming we eventually have more tests in this file; right now this is actually more code in order to theoretically reduce future duplication.)

Copy link
Contributor

@mvanbeusekom mvanbeusekom Oct 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

}

- (void)testOrientationNotifications {
Expand Down