Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Fix webview_flutter Android integration tests and add Espresso #4147

Merged
fluttergithubbot merged 25 commits into from
Jul 26, 2021
Merged

Fix webview_flutter Android integration tests and add Espresso #4147

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
18e6d22
lets see if integration tests run
bparrishMines Jul 8, 2021
2025b84
change folder name
bparrishMines Jul 12, 2021
ddf5d91
create a running test with ./gradlew app:connectedAndroidTest -Ptarge…
bparrishMines Jul 13, 2021
562cc4d
see if tests run on ci?.
bparrishMines Jul 14, 2021
cad641b
fix a few tests
bparrishMines Jul 17, 2021
b94cfbb
try get all tests passing
bparrishMines Jul 17, 2021
744c395
fluttertestrunner and placeholder test
bparrishMines Jul 18, 2021
6d9f282
formatting
bparrishMines Jul 18, 2021
e5ea80c
fix blank test, formatting, license
bparrishMines Jul 18, 2021
2489c44
undo formatting change and remove navigation delegate
bparrishMines Jul 18, 2021
76d612e
Improve example test and version bump test dependencies
bparrishMines Jul 19, 2021
dc6be9a
remove assertequals
bparrishMines Jul 19, 2021
8713690
small format changes
bparrishMines Jul 19, 2021
648e94c
license
bparrishMines Jul 19, 2021
3619762
remove truth dependency, change core dep and follow example
bparrishMines Jul 19, 2021
ffe0058
undo the test change
bparrishMines Jul 19, 2021
f624087
Merge branch 'master' of github.com:flutter/plugins into androidTest
bparrishMines Jul 20, 2021
a10bfde
readd analysisoptions
bparrishMines Jul 20, 2021
42b7238
remove top line
bparrishMines Jul 20, 2021
927b9fe
empty commit to check for flakes
bparrishMines Jul 20, 2021
089fa76
skip tests
bparrishMines Jul 22, 2021
77b45f1
Merge branch 'master' of github.com:flutter/plugins into androidTest
bparrishMines Jul 22, 2021
7e73bb1
remove webview_flutter
bparrishMines Jul 22, 2021
79d82c4
Merge branch 'master' of github.com:flutter/plugins into androidTest
bparrishMines Jul 22, 2021
d34c705
Merge branch 'master' into androidTest
bparrishMines Jul 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
formatting
  • Loading branch information
@bparrishMines
bparrishMines committed Jul 18, 2021
commit 6d9f28200969fa48b12a1deedd80b5e1c92f345f
3 changes: 2 additions & 1 deletion ...d/app/src/androidTest/java/io/flutter/plugins/webviewflutterexample/MainActivityTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,6 @@
@RunWith(FlutterTestRunner.class)
public class MainActivityTest {
@Rule
public final ActivityTestRule<FlutterActivity> rule = new ActivityTestRule<>(FlutterActivity.class);
public final ActivityTestRule<FlutterActivity> rule =
new ActivityTestRule<>(FlutterActivity.class);
}
3 changes: 2 additions & 1 deletion ...ndroid/app/src/androidTest/java/io/flutter/plugins/webviewflutterexample/WebViewTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
package io.flutter.plugins.webviewflutterexample;

import org.junit.Test;
import static org.junit.Assert.assertEquals;

import org.junit.Test;

public class WebViewTest {
Copy link

@blasten blasten Jul 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what runner is this using? do you want to use AndroidJUnit4?

Copy link
Contributor Author

@bparrishMines bparrishMines Jul 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my understanding of Gradle, it uses AndroidJUnit4 as default because of https://github.com/flutter/plugins/blob/master/packages/webview_flutter/example/android/app/build.gradle#L41

Copy link
Contributor Author

@bparrishMines bparrishMines Jul 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also explained here https://developer.android.com/training/testing/junit-runner#ato-gradle

Copy link

@blasten blasten Jul 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

@Test
public void placeHolderTest() {
Expand Down