Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
81 commits
Select commit Hold shift + click to select a range
2b7aa9b
Base classes to support Android camera features
mvanbeusekom Apr 8, 2021
f780742
Fixed formatting
mvanbeusekom Apr 8, 2021
76bc5bd
Applied feedback from PR
mvanbeusekom Apr 20, 2021
0bbed99
Added Android FPS range, resolution and sensor orientation features
mvanbeusekom Apr 8, 2021
1ba738d
Use mockito-inline
mvanbeusekom Apr 9, 2021
de4e70f
Merge remote-tracking branch 'upstream/master' into camera-android/fp…
mvanbeusekom Apr 21, 2021
728346a
Fix issue Pixel 4A
mvanbeusekom May 26, 2021
c014fe3
Merge remote-tracking branch 'upstream/master' into camera-android/fp…
mvanbeusekom May 31, 2021
84f5e73
Added API documentation
mvanbeusekom May 31, 2021
f763f77
Processed feedback on PR
mvanbeusekom May 31, 2021
4a7c73a
Fix formatting
mvanbeusekom May 31, 2021
a890919
Fix formatting
mvanbeusekom May 31, 2021
f60a0d3
Merge remote-tracking branch 'upstream/master'
BeMacized Jun 8, 2021
55a6702
Only exclude 60 FPS limit for Pixel 4a
mvanbeusekom Jun 8, 2021
cd53321
Removed redundant empty line
mvanbeusekom Jun 8, 2021
35831d3
Fixed comment
mvanbeusekom Jun 8, 2021
a9f3142
Test Pixel 4a workaround
mvanbeusekom Jun 8, 2021
551800e
Add tests for orientation updates
mvanbeusekom Jun 10, 2021
68cbc56
Fix formatting
mvanbeusekom Jun 10, 2021
1b137c2
Fix formatting
mvanbeusekom Jun 10, 2021
6514a00
Added missing license header
mvanbeusekom Jun 10, 2021
baae5f6
Add feature classes for exposure- and focus point functionality.
BeMacized Jun 10, 2021
cae8a90
Merge remote-tracking branch 'upstream/master'
BeMacized Jun 11, 2021
94fed08
Added noise reduction feature
BeMacized Jun 14, 2021
be05e67
Merge branch 'camera-android/noise_reduction_feature' into camera-and…
BeMacized Jun 14, 2021
a68b9fb
Merge branch 'camera-android/exposure_focus_point_features' into came…
BeMacized Jun 14, 2021
e5253c1
Merge remote-tracking branch 'origin/camera-android/fps_resolution_se…
BeMacized Jun 14, 2021
4f169ab
Implemented PR feedback
BeMacized Jun 15, 2021
3a68294
Implemented PR feedback
BeMacized Jun 15, 2021
70dbbd5
Add supporting functionality for android refactor
BeMacized Jun 15, 2021
8e65f33
Merge branch 'camera-android/exposure_focus_point_features' into came…
BeMacized Jun 16, 2021
2c64ea2
Merge branch 'camera-android/noise_reduction_feature' into camera-and…
BeMacized Jun 16, 2021
ab332ee
Update packages/camera/camera/android/src/main/java/io/flutter/plugin…
BeMacized Jun 16, 2021
bc16dd3
Update packages/camera/camera/android/src/main/java/io/flutter/plugin…
BeMacized Jun 16, 2021
a85e312
Update packages/camera/camera/android/src/main/java/io/flutter/plugin…
BeMacized Jun 16, 2021
84d6db2
Update packages/camera/camera/android/src/main/java/io/flutter/plugin…
BeMacized Jun 16, 2021
071e879
Update packages/camera/camera/android/src/main/java/io/flutter/plugin…
BeMacized Jun 16, 2021
273762b
Update packages/camera/camera/android/src/test/java/io/flutter/plugin…
BeMacized Jun 16, 2021
e9e9bc5
Update packages/camera/camera/android/src/test/java/io/flutter/plugin…
BeMacized Jun 16, 2021
1af5437
Update packages/camera/camera/android/src/test/java/io/flutter/plugin…
BeMacized Jun 16, 2021
b49b743
Added documentation to DartMessenger
mvanbeusekom Jun 16, 2021
5b8c0d8
Update packages/camera/camera/android/src/main/java/io/flutter/plugin…
BeMacized Jun 16, 2021
62a2f21
Add missing CaptureTimeoutsWrapper documentation
BeMacized Jun 16, 2021
43c0716
Update packages/camera/camera/android/src/main/java/io/flutter/plugin…
BeMacized Jun 16, 2021
24c6c9a
Added documentation to the CameraCaptureCallback
mvanbeusekom Jun 16, 2021
fc2d78b
Merge branch 'camera-android/supporting_functionality' of github.com:…
mvanbeusekom Jun 16, 2021
b2536d4
Add missing documentation for ImageSaver runnable
BeMacized Jun 16, 2021
1748503
Merge remote-tracking branch 'origin/camera-android/supporting_functi…
BeMacized Jun 16, 2021
3118680
Update packages/camera/camera/android/src/main/java/io/flutter/plugin…
BeMacized Jun 16, 2021
7dbbdce
Added documentation to the CameraFeatureFactory
mvanbeusekom Jun 16, 2021
2b2bea3
Configure log tag in one place and optimised loggin
mvanbeusekom Jun 16, 2021
96d285b
Android rework finalization (wip)
BeMacized Jun 16, 2021
81920e0
Progress on final implementation of android rework
BeMacized Jun 16, 2021
6fe67da
Update tests
BeMacized Jun 16, 2021
7f0180e
Accept cameraName as String
mvanbeusekom Jun 16, 2021
24af367
Format
mvanbeusekom Jun 16, 2021
a987711
Changes required for integrating main camera class
BeMacized Jun 16, 2021
66a713d
Merge branch 'camera-android/fps_resolution_sensor_features' into cam…
BeMacized Jun 16, 2021
ce9df6c
Changes required for integrating main camera class
BeMacized Jun 16, 2021
32cb969
Remove debug statement
BeMacized Jun 16, 2021
44acbf7
Merge branch 'camera-android/supporting_functionality' into camera-an…
BeMacized Jun 16, 2021
dd3416b
Updated pubspec version and changelog
BeMacized Jun 16, 2021
d215ac7
Merge branch 'master' into camera-android/supporting_functionality
BeMacized Jun 22, 2021
d10397a
Merge branch 'camera-android/supporting_functionality' into camera-an…
BeMacized Jun 22, 2021
914b187
Merge branch 'master' into camera-android/supporting_functionality
BeMacized Jun 24, 2021
6e13430
Merge branch 'camera-android/supporting_functionality' into camera-an…
BeMacized Jun 24, 2021
9282d9a
Remove unused classes after refactor
BeMacized Jun 28, 2021
cb3a35c
Fix camera orientation issues
BeMacized Jun 28, 2021
5cfbf1c
Merge branch 'camera-android/final-rework-implementation' into fix/ca…
BeMacized Jun 28, 2021
5e3eac8
Fix unit tests
BeMacized Jun 29, 2021
9779a28
Fix rotation issues with exposure- and focus point features.
BeMacized Jul 8, 2021
90000ce
Fix unit tests & Format
BeMacized Jul 12, 2021
3b7f053
Add unit tests for metering rectangle rotation
BeMacized Jul 12, 2021
6bb305e
Merge branch 'master' into camera-android/final-rework-implementation
BeMacized Jul 12, 2021
8e44421
Merge branch 'camera-android/final-rework-implementation' into fix/ca…
BeMacized Jul 12, 2021
36d7173
Revert adjustments to platform interface to prevent unnecessary break…
BeMacized Jul 13, 2021
a2607d1
Revert naming refactor
BeMacized Jul 13, 2021
9fb1019
Update project.pbxproj
BeMacized Jul 13, 2021
777c696
Undo version bump
BeMacized Jul 13, 2021
6c8f16e
Merge branch 'camera-android/final-rework-implementation' into fix/ca…
BeMacized Jul 13, 2021
5d9fb6d
Updated changelog and pubspec version
BeMacized Jul 13, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add supporting functionality for android refactor
  • Loading branch information
BeMacized committed Jun 15, 2021
commit 70dbbd5ff8c457d436a36c3703537263ab934e33
Original file line number Diff line number Diff line change
@@ -0,0 +1,142 @@
// Copyright 2019 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

package io.flutter.plugins.camera;

import android.hardware.camera2.CameraCaptureSession;
import android.hardware.camera2.CameraCaptureSession.CaptureCallback;
import android.hardware.camera2.CaptureRequest;
import android.hardware.camera2.CaptureResult;
import android.hardware.camera2.TotalCaptureResult;
import android.util.Log;
import androidx.annotation.NonNull;
import io.flutter.plugins.camera.types.CaptureTimeoutsWrapper;

class CameraCaptureCallback extends CaptureCallback {
private final CameraCaptureStateListener cameraStateListener;
private CameraState cameraState;
private final CaptureTimeoutsWrapper captureTimeouts;

private CameraCaptureCallback(
@NonNull CameraCaptureStateListener cameraStateListener,
@NonNull CaptureTimeoutsWrapper captureTimeouts) {
cameraState = CameraState.STATE_PREVIEW;
this.cameraStateListener = cameraStateListener;
this.captureTimeouts = captureTimeouts;
}

public static CameraCaptureCallback create(
@NonNull CameraCaptureStateListener cameraStateListener,
@NonNull CaptureTimeoutsWrapper captureTimeouts) {
return new CameraCaptureCallback(cameraStateListener, captureTimeouts);
}

public CameraState getCameraState() {
return cameraState;
}

public void setCameraState(@NonNull CameraState state) {
cameraState = state;
}

private void process(CaptureResult result) {
Integer aeState = result.get(CaptureResult.CONTROL_AE_STATE);
Integer afState = result.get(CaptureResult.CONTROL_AF_STATE);

if (cameraState != CameraState.STATE_PREVIEW) {
Log.i(
"Camera",
"CameraCaptureCallback | state: "
+ cameraState
+ " | afState: "
+ afState
+ " | aeState: "
+ aeState);
}

switch (cameraState) {
case STATE_PREVIEW:
{
// We have nothing to do when the camera preview is working normally.
break;
}
case STATE_WAITING_FOCUS:
{
if (afState == null) {
return;
} else if (afState == CaptureResult.CONTROL_AF_STATE_FOCUSED_LOCKED
|| afState == CaptureResult.CONTROL_AF_STATE_NOT_FOCUSED_LOCKED) {
handleWaitingFocusState(aeState);
} else if (captureTimeouts.getPreCaptureFocusing().getIsExpired()) {
Log.w("Camera", "Focus timeout, moving on with capture");
handleWaitingFocusState(aeState);
}

break;
}
case STATE_WAITING_PRECAPTURE_START:
{
// CONTROL_AE_STATE can be null on some devices
if (aeState == null
|| aeState == CaptureResult.CONTROL_AE_STATE_CONVERGED
|| aeState == CaptureResult.CONTROL_AE_STATE_PRECAPTURE
|| aeState == CaptureResult.CONTROL_AE_STATE_FLASH_REQUIRED) {
setCameraState(CameraState.STATE_WAITING_PRECAPTURE_DONE);
} else if (captureTimeouts.getPreCaptureMetering().getIsExpired()) {
Log.w(
"Camera",
"Metering timeout waiting for pre-capture to start, moving on with capture");

setCameraState(CameraState.STATE_WAITING_PRECAPTURE_DONE);
}
break;
}
case STATE_WAITING_PRECAPTURE_DONE:
{
// CONTROL_AE_STATE can be null on some devices
if (aeState == null || aeState != CaptureResult.CONTROL_AE_STATE_PRECAPTURE) {
cameraStateListener.onConverged();
} else if (captureTimeouts.getPreCaptureMetering().getIsExpired()) {
Log.w(
"Camera",
"Metering timeout waiting for pre-capture to finish, moving on with capture");
cameraStateListener.onConverged();
}

break;
}
}
}

private void handleWaitingFocusState(Integer aeState) {
// CONTROL_AE_STATE can be null on some devices
if (aeState == null || aeState == CaptureRequest.CONTROL_AE_STATE_CONVERGED) {
cameraStateListener.onConverged();
} else {
cameraStateListener.onPrecapture();
}
}

@Override
public void onCaptureProgressed(
@NonNull CameraCaptureSession session,
@NonNull CaptureRequest request,
@NonNull CaptureResult partialResult) {
process(partialResult);
}

@Override
public void onCaptureCompleted(
@NonNull CameraCaptureSession session,
@NonNull CaptureRequest request,
@NonNull TotalCaptureResult result) {
process(result);
}

interface CameraCaptureStateListener {
void onConverged();

void onPrecapture();
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
// Copyright 2019 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

package io.flutter.plugins.camera;

/**
* These are the states that the camera can be in. The camera can only take one photo at a time so
* this state describes the state of the camera itself. The camera works like a pipeline where we
* feed it requests through. It can only process one tasks at a time.
*/
public enum CameraState {
/** Idle, showing preview and not capturing anything. */
STATE_PREVIEW,

/** Starting and waiting for autofocus to complete. */
STATE_WAITING_FOCUS,

/** Start performing autoexposure. */
STATE_WAITING_PRECAPTURE_START,

/** waiting for autoexposure to complete. */
STATE_WAITING_PRECAPTURE_DONE,

/** Capturing an image. */
STATE_CAPTURING,
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,83 @@
// Copyright 2019 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

package io.flutter.plugins.camera;

import android.media.Image;
import androidx.annotation.NonNull;
import androidx.annotation.VisibleForTesting;
import java.io.File;
import java.io.FileNotFoundException;
import java.io.FileOutputStream;
import java.io.IOException;
import java.nio.ByteBuffer;

/** Saves a JPEG {@link Image} into the specified {@link File}. */
public class ImageSaver implements Runnable {

/** The JPEG image */
private final Image mImage;

/** The file we save the image into. */
private final File mFile;

/** Used to report the status of the save action. */
private final Callback mCallback;

ImageSaver(@NonNull Image image, @NonNull File file, @NonNull Callback callback) {
mImage = image;
mFile = file;
mCallback = callback;
}

@Override
public void run() {
ByteBuffer buffer = mImage.getPlanes()[0].getBuffer();
byte[] bytes = new byte[buffer.remaining()];
buffer.get(bytes);
FileOutputStream output = null;
try {
output = FileOutputStreamFactory.create(mFile);
output.write(bytes);

mCallback.onComplete(mFile.getAbsolutePath());

} catch (IOException e) {
mCallback.onError("IOError", "Failed saving image");
} finally {
mImage.close();
if (null != output) {
try {
output.close();
} catch (IOException e) {
mCallback.onError("cameraAccess", e.getMessage());
}
}
}
}

public interface Callback {
void onComplete(String absolutePath);

void onError(String errorCode, String errorMessage);
}

/** Factory class that assists in creating a {@link FileOutputStream} instance. */
static class FileOutputStreamFactory {
/**
* Creates a new instance of the {@link FileOutputStream} class.
*
* <p>This method is visible for testing purposes only and should never be used outside this *
* class.
*
* @param file - The file to create the output stream for
* @return new instance of the {@link FileOutputStream} class.
* @throws FileNotFoundException when the supplied file could not be found.
*/
@VisibleForTesting
public static FileOutputStream create(File file) throws FileNotFoundException {
return new FileOutputStream(file);
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,135 @@
// Copyright 2019 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

package io.flutter.plugins.camera.features;

import android.app.Activity;
import androidx.annotation.NonNull;
import io.flutter.plugins.camera.CameraProperties;
import io.flutter.plugins.camera.DartMessenger;
import io.flutter.plugins.camera.features.autofocus.AutoFocusFeature;
import io.flutter.plugins.camera.features.exposurelock.ExposureLockFeature;
import io.flutter.plugins.camera.features.exposureoffset.ExposureOffsetFeature;
import io.flutter.plugins.camera.features.exposurepoint.ExposurePointFeature;
import io.flutter.plugins.camera.features.flash.FlashFeature;
import io.flutter.plugins.camera.features.focuspoint.FocusPointFeature;
import io.flutter.plugins.camera.features.fpsrange.FpsRangeFeature;
import io.flutter.plugins.camera.features.noisereduction.NoiseReductionFeature;
import io.flutter.plugins.camera.features.resolution.ResolutionFeature;
import io.flutter.plugins.camera.features.resolution.ResolutionPreset;
import io.flutter.plugins.camera.features.sensororientation.SensorOrientationFeature;
import io.flutter.plugins.camera.features.zoomlevel.ZoomLevelFeature;

public interface CameraFeatureFactory {

/**
* Creates a new instance of the auto focus feature.
*
* @param cameraProperties instance of the CameraProperties class containing information about the
* cameras features.
* @param recordingVideo indicates if the camera is currently recording.
* @return newly created instance of the AutoFocusFeature class.
*/
AutoFocusFeature createAutoFocusFeature(
@NonNull CameraProperties cameraProperties, boolean recordingVideo);

/**
* Creates a new instance of the exposure lock feature.
*
* @param cameraProperties instance of the CameraProperties class containing information about the
* cameras features.
* @return newly created instance of the ExposureLockFeature class.
*/
ExposureLockFeature createExposureLockFeature(@NonNull CameraProperties cameraProperties);

/**
* Creates a new instance of the exposure offset feature.
*
* @param cameraProperties instance of the CameraProperties class containing information about the
* cameras features.
* @return newly created instance of the ExposureOffsetFeature class.
*/
ExposureOffsetFeature createExposureOffsetFeature(@NonNull CameraProperties cameraProperties);

/**
* Creates a new instance of the flash feature.
*
* @param cameraProperties instance of the CameraProperties class containing information about the
* cameras features.
* @return newly created instance of the FlashFeature class.
*/
FlashFeature createFlashFeature(@NonNull CameraProperties cameraProperties);

/**
* Creates a new instance of the resolution feature.
*
* @param cameraProperties instance of the CameraProperties class containing information about the
* cameras features.
* @param initialSetting initial resolution preset.
* @param cameraId - the id of the camera which can be used to identify the camera device.
* @return newly created instance of the ResolutionFeature class.
*/
ResolutionFeature createResolutionFeature(
@NonNull CameraProperties cameraProperties, ResolutionPreset initialSetting, int cameraId);

/**
* Creates a new instance of the focus point feature.
*
* @param cameraProperties instance of the CameraProperties class containing information about the
* cameras features.
* @return newly created instance of the FocusPointFeature class.
*/
FocusPointFeature createFocusPointFeature(@NonNull CameraProperties cameraProperties);

/**
* Creates a new instance of the FPS range feature.
*
* @param cameraProperties instance of the CameraProperties class containing information about the
* cameras features.
* @return newly created instance of the FpsRangeFeature class.
*/
FpsRangeFeature createFpsRangeFeature(@NonNull CameraProperties cameraProperties);

/**
* Creates a new instance of the sensor orientation feature.
*
* @param cameraProperties instance of the CameraProperties class containing information about the
* cameras features.
* @param activity current activity associated with the camera plugin.
* @param dartMessenger instance of the DartMessenger class, used to send state updates back to
* Dart.
* @return newly created instance of the SensorOrientationFeature class.
*/
SensorOrientationFeature createSensorOrientationFeature(
@NonNull CameraProperties cameraProperties,
@NonNull Activity activity,
@NonNull DartMessenger dartMessenger);

/**
* Creates a new instance of the zoom level feature.
*
* @param cameraProperties instance of the CameraProperties class containing information about the
* cameras features.
* @return newly created instance of the ZoomLevelFeature class.
*/
ZoomLevelFeature createZoomLevelFeature(@NonNull CameraProperties cameraProperties);

/**
* Creates a new instance of the exposure point feature.
*
* @param cameraProperties instance of the CameraProperties class containing information about the
* cameras features.
* @return newly created instance of the ExposurePointFeature class.
*/
ExposurePointFeature createExposurePointFeature(@NonNull CameraProperties cameraProperties);

/**
* Creates a new instance of the noise reduction feature.
*
* @param cameraProperties instance of the CameraProperties class containing information about the
* cameras features.
* @return newly created instance of the NoiseReductionFeature class.
*/
NoiseReductionFeature createNoiseReductionFeature(@NonNull CameraProperties cameraProperties);
}
Loading