Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[url_launcher] Add native unit tests for Windows #4156

Merged
stuartmorgan-g merged 12 commits into from
Aug 17, 2021
Merged

[url_launcher] Add native unit tests for Windows #4156

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
6b6d723
Initial proof of concept
stuartmorgan-g Jul 9, 2021
99b2ab1
Refactor file structure, plugin class, for testability
stuartmorgan-g Jul 13, 2021
bc94f32
Add real tests, and make them build.
stuartmorgan-g Jul 14, 2021
e239b3d
Tweaks
stuartmorgan-g Jul 14, 2021
ec3b3e2
Update changelog
stuartmorgan-g Jul 14, 2021
a6a1e8b
Improve the filename mess
stuartmorgan-g Jul 14, 2021
ce8bb54
Format
stuartmorgan-g Jul 14, 2021
eb432df
Merge branch 'master' into windows-unit-test
stuartmorgan-g Jul 26, 2021
8542f52
Missing license
stuartmorgan-g Jul 26, 2021
3032865
Merge branch 'master' into windows-unit-test
stuartmorgan-g Aug 17, 2021
cef2f07
Fix weird autoformat
stuartmorgan-g Aug 17, 2021
c5c0a8f
Fix weird autoformat
stuartmorgan-g Aug 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Format
  • Loading branch information
@stuartmorgan-g
stuartmorgan-g committed Jul 14, 2021
commit ce8bb54d7bba50a11ed419c317ebc580fae28303
3 changes: 1 addition & 2 deletions packages/url_launcher/url_launcher_windows/windows/test/url_launcher_windows_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,7 @@ TEST(UrlLauncherPlugin, CanLaunchHandlesOpenFailure) {
std::make_unique<MockMethodResult>();

// Return failure for opening.
EXPECT_CALL(*system, RegOpenKeyExW)
.WillOnce(Return(ERROR_BAD_PATHNAME));
EXPECT_CALL(*system, RegOpenKeyExW).WillOnce(Return(ERROR_BAD_PATHNAME));
// Expect a success response.
EXPECT_CALL(*result, SuccessInternal(Pointee(EncodableValue(false))));

Expand Down