Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[google_sign_in] Add serverAuthCode attribute to google_sign_in_platform_interface user data #4179

Merged
merged 7 commits into from
Oct 8, 2021
Merged

[google_sign_in] Add serverAuthCode attribute to google_sign_in_platform_interface user data #4179

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
47f4783
obtain serverAuthCode on login
p-shapovalov Jul 22, 2021
8d114bb
fix changelog
p-shapovalov Jul 22, 2021
33783f0
tests fix
p-shapovalov Jul 23, 2021
ffae44e
Merge branch 'master' of https://github.com/flutter/plugins into fix/…
p-shapovalov Oct 8, 2021
602a5f5
version
p-shapovalov Oct 8, 2021
f6ea301
Revert "version"
p-shapovalov Oct 8, 2021
bb6607d
version fix
p-shapovalov Oct 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tests fix
  • Loading branch information
@p-shapovalov
p-shapovalov committed Jul 23, 2021
commit 33783f04e85dfca476783e3b117df489a2e333d7
2 changes: 2 additions & 0 deletions ...le_sign_in/google_sign_in_platform_interface/test/method_channel_google_sign_in_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ const Map<String, String> kUserData = <String, String>{
"id": "8162538176523816253123",
"photoUrl": "https://lh5.googleusercontent.com/photo.jpg",
"displayName": "John Doe",
'idToken': '123',
Copy link
Contributor

@cyanglaz cyanglaz Oct 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the test data gets validated anywhere. I'd imagine there should be something like;

expect(user.serverAuthCode, kUserData['serverAuthCode']);

(Thanks for adding the idToken)

Copy link
Contributor Author

@p-shapovalov p-shapovalov Oct 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check #4179 (comment)

Copy link
Contributor

@cyanglaz cyanglaz Oct 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh make sense, thanks

'serverAuthCode': '789',
};

const Map<dynamic, dynamic> kTokenData = <String, dynamic>{
Expand Down