Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[google_sign_in] add serverAuthCode to GoogleSignInAccount #4180

Merged
merged 14 commits into from
Oct 21, 2021
Merged

[google_sign_in] add serverAuthCode to GoogleSignInAccount #4180

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
2c6f55e
reuse serverAuthCode obtained on login
p-shapovalov Jul 22, 2021
8291838
tests fix
p-shapovalov Jul 23, 2021
5b011ae
Merge branch 'master' into fix/reuse-server-auth-code
p-shapovalov Jul 26, 2021
f17f84e
Merge branch 'master' into fix/reuse-server-auth-code
p-shapovalov Aug 5, 2021
b7b9be2
Merge branch 'master' into fix/reuse-server-auth-code
p-shapovalov Aug 28, 2021
258087c
Merge branch 'master' into fix/reuse-server-auth-code
p-shapovalov Oct 8, 2021
c97830f
move serverAuthCode to GoogleSignInAccount
p-shapovalov Oct 8, 2021
f9097ff
avoid breaking changes
p-shapovalov Oct 8, 2021
6c63d81
pass GoogleSignInAccount.serverAuthCode to GoogleSignInAuthentication
p-shapovalov Oct 8, 2021
58a16b3
restore prev behaviour for deprecated serverAuthCode
p-shapovalov Oct 8, 2021
bebb406
restore deprecated test
p-shapovalov Oct 8, 2021
28194da
Trigger Build
p-shapovalov Oct 15, 2021
e092b7a
Merge branch 'fix/reuse-server-auth-code' of https://github.com/p-sha…
p-shapovalov Oct 15, 2021
885e1c1
fix deprecated_member_use_from_same_package
p-shapovalov Oct 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix deprecated_member_use_from_same_package
  • Loading branch information
@p-shapovalov
p-shapovalov committed Oct 15, 2021
commit 885e1c184ba5cbbc038dfe4fe2ded5d984261e71
3 changes: 2 additions & 1 deletion packages/google_sign_in/google_sign_in/test/google_sign_in_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,8 @@ void main() {

expect(auth.accessToken, '456');
expect(auth.idToken, '123');
expect(auth.serverAuthCode, '789');
// fix deprecated_member_use_from_same_package
// expect(auth.serverAuthCode, '789');
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g Oct 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was commented-out code checked in?

Copy link
Contributor

@cyanglaz cyanglaz Oct 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, sorry I should have caught it. I'll create a PR to remove it

Copy link
Contributor

@cyanglaz cyanglaz Oct 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#4442

expect(
log,
<Matcher>[
Expand Down