Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[flutter_plugin_tools] Validate pubspec description #4396

Merged
merged 4 commits into from
Sep 30, 2021
Merged

[flutter_plugin_tools] Validate pubspec description #4396

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c4d3983
Check the description length in pubspec-check
stuartmorgan-g Sep 29, 2021
ae5873a
Fix violations
stuartmorgan-g Sep 29, 2021
8633692
Update plugin_platform_interface
stuartmorgan-g Sep 29, 2021
dd6d0d2
Typo fix
stuartmorgan-g Sep 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Typo fix 
Co-authored-by: Maurits van Beusekom <[email protected]>
  • Loading branch information
@stuartmorgan-g @mvanbeusekom
stuartmorgan-g and mvanbeusekom authored Sep 30, 2021
commit dd6d0d2a17a89a1302040279e3885a66cf64e380
2 changes: 1 addition & 1 deletion script/tool/lib/src/common/repository_package.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ class RepositoryPackage {
/// repository conventions.
bool get isPlatformImplementation =>
Copy link
Member

@ditman ditman Sep 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be determined by the presence of the implements pubspec.yaml property?

Copy link
Contributor Author

@stuartmorgan-g stuartmorgan-g Sep 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we ever find that this heuristic isn't working, that's the way to go (and by having it centralized here was can easily improve it later). That's way more involved though since it requires loading and parsing the pubspec, and I suspect the heuristic may well be all we ever need.

// Any part of a federated plugin that isn't the platform interface and
// isn't the app-facing packagke should be an implementation package.
// isn't the app-facing package should be an implementation package.
isFederated &&
!isPlatformInterface &&
directory.basename != directory.parent.basename;
Expand Down